Issue 9651030: Add Chrome To Mobile png images; lit/unlit and high res.

Issue 9651030: Add Chrome To Mobile png images; lit/unlit and high res. (Closed)

Created:
8 years, 9 months ago by msw

Modified:
8 years, 9 months ago

Reviewers:
sail

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add Chrome To Mobile png images; lit/unlit and high res. Add chrome/app/theme/mobile[_lit][_1_25x|2x].png files. I ran PNGCrush and PNGSlim (6,710 bytes -> 814 bytes). BUG=102709 TEST=none, adding images. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=126263

Patch Set 1 #

Patch Set 2 : Add new mobile resources. #

Total comments: 2

Patch Set 3 : Remove mistaken whitespace change. #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set			Patch
A	chrome/app/theme/mobile.png	View	1	+-1 lines, --1 lines	0 comments	Download
A	chrome/app/theme/mobile_1_25x.png	View	1	+-1 lines, --1 lines	0 comments	Download
A	chrome/app/theme/mobile_2x.png	View	1	+-1 lines, --1 lines	0 comments	Download
A	chrome/app/theme/mobile_lit.png	View	1	+-1 lines, --1 lines	0 comments	Download
A	chrome/app/theme/mobile_lit_1_25x.png	View	1	+-1 lines, --1 lines	0 comments	Download
A	chrome/app/theme/mobile_lit_2x.png	View	1	+-1 lines, --1 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

msw

PTAL; thanks! Do we need a bluish icon like chrome/app/theme/star.png? Do we need a 1.25x ...

8 years, 9 months ago (2012-03-09 07:50:47 UTC) #1

sail

we definitely need hires versions for m19. it's ok to check them in separately as ...

8 years, 9 months ago (2012-03-09 18:40:47 UTC) #2

sail

lgtm https://chromiumcodereview.appspot.com/9651030/diff/8010/ui/views/view.h File ui/views/view.h (right): https://chromiumcodereview.appspot.com/9651030/diff/8010/ui/views/view.h#newcode1 ui/views/view.h:1: // Copyright (c) 2012 The Chromium Authors. All ...

8 years, 9 months ago (2012-03-12 21:36:35 UTC) #4

msw

8 years, 9 months ago (2012-03-12 21:57:34 UTC) #5

Yup, I removed the mistaken whitespace change; thanks!
Landing when the tree goes green.

https://chromiumcodereview.appspot.com/9651030/diff/8010/ui/views/view.h
File ui/views/view.h (right):

https://chromiumcodereview.appspot.com/9651030/diff/8010/ui/views/view.h#newc...
ui/views/view.h:1: // Copyright (c) 2012 The Chromium Authors. All rights
reserved.
On 2012/03/12 21:36:35, sail wrote:
> extra file in CL?

Done.

Expand Messages | Collapse Messages