Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(693)

Issue 9651024: [Web Intents] Fix crash in views picker. (Closed)

Created:
8 years, 9 months ago by binji
Modified:
8 years, 9 months ago
Reviewers:
James Hawkins
CC:
chromium-reviews
Visibility:
Public.

Description

[Web Intents] Fix crash in views picker. Crash occurs because the previous code would early-out when there were no services installed, which would prevent creating the LayoutManager. As a result, the layout manager was NULL. BUG=117068 TEST=none TBR=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=126723

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M chrome/browser/ui/views/web_intent_picker_views.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
binji
8 years, 9 months ago (2012-03-09 02:51:24 UTC) #1
James Hawkins
lgtm
8 years, 9 months ago (2012-03-09 02:54:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/binji@chromium.org/9651024/1
8 years, 9 months ago (2012-03-12 18:42:57 UTC) #3
commit-bot: I haz the power
Try job failure for 9651024-1 (retry) on win_rel for steps "ui_tests, browser_tests, check_deps". It's a ...
8 years, 9 months ago (2012-03-12 21:32:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/binji@chromium.org/9651024/1
8 years, 9 months ago (2012-03-13 15:27:08 UTC) #5
commit-bot: I haz the power
8 years, 9 months ago (2012-03-13 17:15:18 UTC) #6
Try job failure for 9651024-1 (retry) on win_rel for step "update".
It's a second try, previously, steps "browser_tests, installer_util_unittests"
failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

Step "update" is always a major failure.
Look at the try server FAQ for more details.

Powered by Google App Engine
This is Rietveld 408576698