Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 9651023: Get the ProfileService object after NOTIFICATION_SESSION_STARTED is sent to Chrome (Closed)

Created:
8 years, 9 months ago by Yusuke Sato
Modified:
8 years, 9 months ago
Reviewers:
stevenjb, Nikita (slow)
CC:
chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org, yusukes+watch_chromium.org, mazda
Visibility:
Public.

Description

Get the ProfileService object after NOTIFICATION_SESSION_STARTED is sent to Chrome. Currently InputMethodMenu continues to read/write the /home/chronos/Default/Preferences file, rather than /home/chronos/user/Preferences, even after sign in because InputMethodMenu gets a pointer to Profile by calling ProfileManager::GetDefaultProfile() *before* sign in. We have to do it after sign in since the GetDefaultProfile() function returns a different instance depending on the user is signed in or not. This is the same fix as http://crrev.com/125787 . BUG=118142 TEST=see the bug Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=126844

Patch Set 1 #

Patch Set 2 : rebase, review #

Total comments: 2

Patch Set 3 : review fix #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -42 lines) Patch
M chrome/browser/chromeos/status/input_method_menu.h View 1 2 3 2 chunks +1 line, -7 lines 0 comments Download
M chrome/browser/chromeos/status/input_method_menu.cc View 1 2 3 9 chunks +26 lines, -22 lines 0 comments Download
M chrome/browser/chromeos/status/input_method_menu_button.cc View 1 2 3 3 chunks +3 lines, -13 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Yusuke Sato
8 years, 9 months ago (2012-03-14 05:18:16 UTC) #1
Nikita (slow)
lgtm http://codereview.chromium.org/9651023/diff/3001/chrome/browser/chromeos/status/input_method_menu.h File chrome/browser/chromeos/status/input_method_menu.h (right): http://codereview.chromium.org/9651023/diff/3001/chrome/browser/chromeos/status/input_method_menu.h#newcode47 chrome/browser/chromeos/status/input_method_menu.h:47: explicit InputMethodMenu(bool for_out_of_box_experience_dialog); nit: for_out_of_box_experience_dialog > for_login_dialog.
8 years, 9 months ago (2012-03-14 11:31:06 UTC) #2
Yusuke Sato
+stevenjb Steven, could you do owners review? http://codereview.chromium.org/9651023/diff/3001/chrome/browser/chromeos/status/input_method_menu.h File chrome/browser/chromeos/status/input_method_menu.h (right): http://codereview.chromium.org/9651023/diff/3001/chrome/browser/chromeos/status/input_method_menu.h#newcode47 chrome/browser/chromeos/status/input_method_menu.h:47: explicit InputMethodMenu(bool ...
8 years, 9 months ago (2012-03-14 14:50:58 UTC) #3
stevenjb
lgtm
8 years, 9 months ago (2012-03-14 16:47:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yusukes@chromium.org/9651023/8003
8 years, 9 months ago (2012-03-15 01:42:23 UTC) #5
commit-bot: I haz the power
8 years, 9 months ago (2012-03-15 04:53:13 UTC) #6
Try job failure for 9651023-8003 (previous was lost) (previous was lost) (retry)
on win for step "compile" (clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...

Powered by Google App Engine
This is Rietveld 408576698