Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Unified Diff: editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/callhierarchy/CalleeAnalyzerVisitor.java

Issue 9651004: Make SourceInfo a class, rename its menthods. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Tweak for formatting, lazily create LainesInfo Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/callhierarchy/CalleeAnalyzerVisitor.java
diff --git a/editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/callhierarchy/CalleeAnalyzerVisitor.java b/editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/callhierarchy/CalleeAnalyzerVisitor.java
index 149373c4151a9bde4970383df56292f6efaf26e6..0b7c30fdcd610b8e8568d9d2aba54e25dc786795 100644
--- a/editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/callhierarchy/CalleeAnalyzerVisitor.java
+++ b/editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/callhierarchy/CalleeAnalyzerVisitor.java
@@ -134,10 +134,10 @@ public class CalleeAnalyzerVisitor extends ASTVisitor<Void> {
if (!isIgnoredBySearchScope(calledMethod)) {
referencedMember = calledMethod;
}
- final int position = node.getSourceStart();
- final int number = node.getSourceLine();
- searchResults.addMember(memberToAnalyze, referencedMember, position,
- position + node.getSourceLength(), number < 1 ? 1 : number);
+ final int position = node.getSourceInfo().getOffset();
+ final int number = node.getSourceInfo().getLine();
+ searchResults.addMember(memberToAnalyze, referencedMember, position, position
+ + node.getSourceInfo().getLength(), number < 1 ? 1 : number);
}
}
@@ -169,8 +169,8 @@ public class CalleeAnalyzerVisitor extends ASTVisitor<Void> {
}
private boolean isNodeEnclosingMethod(DartNode node) {
- int nodeStartPosition = node.getSourceStart();
- int nodeEndPosition = nodeStartPosition + node.getSourceLength();
+ int nodeStartPosition = node.getSourceInfo().getOffset();
+ int nodeEndPosition = nodeStartPosition + node.getSourceInfo().getLength();
if (nodeStartPosition < methodStartPosition && nodeEndPosition > methodEndPosition) {
// Is the method completely enclosed by the node?
@@ -180,8 +180,8 @@ public class CalleeAnalyzerVisitor extends ASTVisitor<Void> {
}
private boolean isNodeWithinMethod(DartNode node) {
- int nodeStartPosition = node.getSourceStart();
- int nodeEndPosition = nodeStartPosition + node.getSourceLength();
+ int nodeStartPosition = node.getSourceInfo().getOffset();
+ int nodeEndPosition = nodeStartPosition + node.getSourceInfo().getLength();
if (nodeStartPosition < methodStartPosition) {
return false;

Powered by Google App Engine
This is Rietveld 408576698