editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/completion/ScopedNameFinder.java - Issue 9651004: Make SourceInfo a class, rename its menthods.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/completion/ScopedNameFinder.java

Issue 9651004: Make SourceInfo a class, rename its menthods. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Tweak for formatting, lazily create LainesInfo Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/completion/CompletionParser.java ('k') | editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/completion/ast/CompletionUtil.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/completion/ScopedNameFinder.java

diff --git a/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/completion/ScopedNameFinder.java b/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/completion/ScopedNameFinder.java

index 4307ebcb988b2edc3e8d4e74369224136487a51c..191c3d25693405b0648cd0978548b3544cc8a657 100644

--- a/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/completion/ScopedNameFinder.java

+++ b/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/completion/ScopedNameFinder.java

@@ -13,6 +13,7 @@

package com.google.dart.tools.core.internal.completion;

+import com.google.dart.compiler.ast.ASTVisitor;

import com.google.dart.compiler.ast.DartBlock;

import com.google.dart.compiler.ast.DartCatchBlock;

import com.google.dart.compiler.ast.DartField;

@@ -24,7 +25,6 @@ import com.google.dart.compiler.ast.DartFunctionTypeAlias;

import com.google.dart.compiler.ast.DartIdentifier;

import com.google.dart.compiler.ast.DartMethodDefinition;

import com.google.dart.compiler.ast.DartNode;

-import com.google.dart.compiler.ast.ASTVisitor;

import com.google.dart.compiler.ast.DartParameter;

import com.google.dart.compiler.ast.DartStatement;

import com.google.dart.compiler.ast.DartSwitchMember;

@@ -319,7 +319,7 @@ public class ScopedNameFinder extends ASTVisitor<Void> {

// if source position is not set then all nodes are in range

return true;

}

- int start = node.getSourceStart();

+ int start = node.getSourceInfo().getOffset();

if (start < 0) {

// assume nodes without source position are in range

return true;