compiler/java/com/google/dart/compiler/resolver/TopLevelElementBuilder.java - Issue 9651004: Make SourceInfo a class, rename its menthods.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: compiler/java/com/google/dart/compiler/resolver/TopLevelElementBuilder.java

Issue 9651004: Make SourceInfo a class, rename its menthods. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Tweak for formatting, lazily create LainesInfo Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « compiler/java/com/google/dart/compiler/resolver/SupertypeResolver.java ('k') | compiler/javatests/com/google/dart/compiler/DeltaBench.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: compiler/java/com/google/dart/compiler/resolver/TopLevelElementBuilder.java

diff --git a/compiler/java/com/google/dart/compiler/resolver/TopLevelElementBuilder.java b/compiler/java/com/google/dart/compiler/resolver/TopLevelElementBuilder.java

index bccedbbbd34615a7a68a241781f14d81752ef037..47d3a412a849c85984f8ccb5bfee19164685be9c 100644

--- a/compiler/java/com/google/dart/compiler/resolver/TopLevelElementBuilder.java

+++ b/compiler/java/com/google/dart/compiler/resolver/TopLevelElementBuilder.java

@@ -93,7 +93,7 @@ public class TopLevelElementBuilder {

}

- void compilationError(DartCompilerListener listener, SourceInfo node, ErrorCode errorCode,

+ private void compilationError(DartCompilerListener listener, SourceInfo node, ErrorCode errorCode,

Object... args) {

DartCompilationError error = new DartCompilationError(node, errorCode, args);

listener.onError(error);

@@ -129,7 +129,7 @@ public class TopLevelElementBuilder {

DartNode nameNode = ((DartDeclaration<DartExpression>) node).getName();

compilationError(

listener,

- nameNode,

+ nameNode.getSourceInfo(),

ResolverErrorCode.DUPLICATE_TOP_LEVEL_DEFINITION,

nameNode);

}