Issue 9649027: Inline inequality compares of strings into CompareICStub.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9649027: Inline inequality compares of strings into CompareICStub. (Closed)

Created:
8 years, 9 months ago by Yang

Modified:
8 years, 9 months ago

Reviewers:
rossberg

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Inline inequality compares of strings into CompareICStub instead of jumping into the CompareStub that handles the generic case. BUG= TEST= Committed: https://code.google.com/p/v8/source/detail?r=10988

Patch Set 1 #

Patch Set 2 : Ported to ia32 and x64. #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+88 lines, -46 lines)			Patch
M	src/arm/code-stubs-arm.cc	View	1	2 chunks	+26 lines, -13 lines	0 comments	Download
M	src/ia32/code-stubs-ia32.cc	View		4 chunks	+29 lines, -16 lines	0 comments	Download
M	src/ic.cc	View		1 chunk	+6 lines, -2 lines	0 comments	Download
M	src/x64/code-stubs-x64.cc	View	1	4 chunks	+27 lines, -15 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Yang

On 2012/03/09 11:00:47, Yang wrote: > PTAL. This is just for ia32 btw. I still ...

8 years, 9 months ago (2012-03-09 11:03:42 UTC) #2

Yang

On 2012/03/09 11:05:45, rossberg wrote: > lgtm Added x64 and arm ports. Please take another ...

8 years, 9 months ago (2012-03-09 11:30:58 UTC) #4

lgtm

Expand Messages | Collapse Messages