Inline functions that use arguments object in f.apply(o, arguments) pattern.

Inline functions that use arguments object in f.apply(o, arguments) pattern.

Support arguments materialization after deoptimization in all frames (not only in topmost one).

R=fschneider@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=11008

[Vyacheslav Egorov (Chromium), 2012-03-09 15:55:43]

this is ready for the review

[fschneider, 2012-03-12 10:13:32]

lgtm

https://chromiumcodereview.appspot.com/9643001/diff/3001/src/hydrogen.cc
File src/hydrogen.cc (right):

https://chromiumcodereview.appspot.com/9643001/diff/3001/src/hydrogen.cc#newc...
src/hydrogen.cc:5233: // If the function uses arguments object check that
inlining of functions
[...] uses _the_ arguments object [...]

https://chromiumcodereview.appspot.com/9643001/diff/3001/src/hydrogen.cc#newc...
src/hydrogen.cc:5234: // with arguments object is enabled and variable arguments
is stack allocated.
[...] and the arguments-variable [...]

https://chromiumcodereview.appspot.com/9643001/diff/3001/src/hydrogen.cc#newc...
src/hydrogen.cc:5707: if (!receiver->IsAllocateObject()) {
You can use receiver->type().IsJSObject() instead. Result of object-literal is
also a JSObject for example.

https://chromiumcodereview.appspot.com/9643001/diff/3001/src/runtime.cc
File src/runtime.cc (right):

https://chromiumcodereview.appspot.com/9643001/diff/3001/src/runtime.cc#newco...
src/runtime.cc:8478: MaterializeArgumentsObjectInFrame(isolate, frame);
You could move this into the loop above with iterating from [0..jsframes[

https://chromiumcodereview.appspot.com/9643001/diff/3001/src/x64/lithium-x64.cc
File src/x64/lithium-x64.cc (right):

https://chromiumcodereview.appspot.com/9643001/diff/3001/src/x64/lithium-x64....
src/x64/lithium-x64.cc:1096: LOperand* receiver =
UseRegisterAtStart(instr->receiver());
I think it does not matter with DefineSameAsFirst, but on ia32 this is defined
as UseRegister. Maybe we should be consistent.

https://chromiumcodereview.appspot.com/9643001/diff/7001/test/mjsunit/compile...
File test/mjsunit/compiler/inline-arguments.js (right):

https://chromiumcodereview.appspot.com/9643001/diff/7001/test/mjsunit/compile...
test/mjsunit/compiler/inline-arguments.js:34: assertTrue(this instanceof A);
Maybe also add a test where the receiver is wrapped. null or undefined, etc.