Remove Pickle::WriteSize() now that it has no remaining callers.

base/pickle.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef BASE_PICKLE_H__
 #define BASE_PICKLE_H__
 #pragma once
 
 #include <string>
 
@@ skipping 80 matching lines @@
   // Methods for adding to the payload of the Pickle.  These values are
   // appended to the end of the Pickle's payload.  When reading values from a
   // Pickle, it is important to read them in the order in which they were added
   // to the Pickle.
   bool WriteBool(bool value) {
     return WriteInt(value ? 1 : 0);
   }
   bool WriteInt(int value) {
     return WriteBytes(&value, sizeof(value));
   }
+  // WARNING: DO NOT USE WriteLong() IF PICKLES ARE PERSISTED IN ANY WAY.
+  // WriteLong() writes whatever a "long" is on this architecture. On 32-bit
+  // platforms, it is 32 bits. On 64-bit platforms, it is 64 bits. If persisted
+  // pickles are still around after upgrading to 64-bit, or if they are copied
+  // between dissimilar systems, YOUR PICKLES WILL HAVE GONE BAD.

[jar (doing other things), 2012/03/09 22:13:36]

IMO, you have discovered a problem.... and it is a bad problem for anyone that
persists data using pickles.  

Rather than having a comment (resetting the mouse-trap, so that it will catch
the next victim, and cost us all), how abut crafting some code to handle this
issue more directly.

Can we get rid of this API?  How many users are there?  Can you migrate them to
a more stable API??

Jim

[Mike Mammarella, 2012/03/10 00:24:42]

Looks like WriteSize() might be feasible to remove, as it's not used in too many
places. (As long as all such places don't persist data, we can just change
them.) WriteLong() is used in the IPC code, which we should be able to change
safely, but it's all over the place. I'll look into it.

That said, this warning can only help compared to doing nothing, and I don't
work full-time on Chrome, so it could take a while for me to investigate this.
I'd like to add the warning for now.

   bool WriteLong(long value) {
     return WriteBytes(&value, sizeof(value));
   }
+  // WARNING: SEE THE WARNING FOR WriteLong() ABOVE. USE WriteSize() CAREFULLY.
   bool WriteSize(size_t value) {
     return WriteBytes(&value, sizeof(value));
   }
   bool WriteUInt16(uint16 value) {
     return WriteBytes(&value, sizeof(value));
   }
   bool WriteUInt32(uint32 value) {
     return WriteBytes(&value, sizeof(value));
   }
   bool WriteInt64(int64 value) {
@@ skipping 129 matching lines @@
   size_t capacity_;
   size_t variable_buffer_offset_;  // IF non-zero, then offset to a buffer.
 
   FRIEND_TEST_ALL_PREFIXES(PickleTest, Resize);
   FRIEND_TEST_ALL_PREFIXES(PickleTest, FindNext);
   FRIEND_TEST_ALL_PREFIXES(PickleTest, FindNextWithIncompleteHeader);
   FRIEND_TEST_ALL_PREFIXES(PickleTest, IteratorHasRoom);
 };
 
 #endif  // BASE_PICKLE_H__