compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java - Issue 9641003: Example of deadlock in test_runner.dart on process crash

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java

Issue 9641003: Example of deadlock in test_runner.dart on process crash (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java

diff --git a/compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java b/compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java

index a317c09bab65e8b2c7f66904583b4bb0eb795938..8da6d96c04c29ba210be4828b4d478c051317405 100644

--- a/compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java

+++ b/compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java

@@ -1158,7 +1158,7 @@ public class TypeAnalyzer implements DartCompilationPhase {

if (returnType != null && returnType.getType() != voidType) {

typeError(returnType, TypeErrorCode.SETTER_RETURN_TYPE, methodElement.getName());

}

- if (currentClass != null && methodElement.getParameters().size() > 0) {

+ if (methodElement.getParameters().size() > 0) {

Element parameterElement = methodElement.getParameters().get(0);

Type setterType = parameterElement.getType();

MethodElement getterElement = Elements.lookupFieldElementGetter(currentClass.getElement(),

« no previous file with comments | « compiler/java/com/google/dart/compiler/UnitTestBatchRunner.java ('k') | tools/testing/dart/test_runner.dart » ('j') | no next file with comments »