Added support functions for using Literal keys in a HashMap.

Added support functions for using Literal keys in a HashMap.

This is a preparatory step for using the HashMap clas with Literal keys in the
full code generator. It removes some duplicated code already and removes the
need for 2 HashMaps at each use, which was overly complicated.

Removed one dead function on the way.

Committed: https://code.google.com/p/v8/source/detail?r=10973

[rossberg, 2012-03-08 16:51:39]

lgtm

https://chromiumcodereview.appspot.com/9639011/diff/1/src/ast.cc
File src/ast.cc (right):

https://chromiumcodereview.appspot.com/9639011/diff/1/src/ast.cc#newcode1148
src/ast.cc:1148: } else {
Nit: indentation.

https://chromiumcodereview.appspot.com/9639011/diff/1/src/ast.h
File src/ast.h (right):

https://chromiumcodereview.appspot.com/9639011/diff/1/src/ast.h#newcode1252
src/ast.h:1252: Handle<String> s2 =
reinterpret_cast<Literal*>(literal2)->ToString();
Could be static_cast.

[Sven Panne, 2012-03-09 08:24:46]

https://chromiumcodereview.appspot.com/9639011/diff/1/src/ast.cc
File src/ast.cc (right):

https://chromiumcodereview.appspot.com/9639011/diff/1/src/ast.cc#newcode1148
src/ast.cc:1148: } else {
On 2012/03/08 16:51:39, rossberg wrote:
> Nit: indentation.

Done.

https://chromiumcodereview.appspot.com/9639011/diff/1/src/ast.h
File src/ast.h (right):

https://chromiumcodereview.appspot.com/9639011/diff/1/src/ast.h#newcode1252
src/ast.h:1252: Handle<String> s2 =
reinterpret_cast<Literal*>(literal2)->ToString();
On 2012/03/08 16:51:39, rossberg wrote:
> Could be static_cast.

Although the real difference between those casts in the presence of void* is not
totally clear to me, I'll switch to static_cast.