Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 9633017: Fix a bug in the x64 elements transition code. (Closed)

Created:
8 years, 9 months ago by fschneider
Modified:
8 years, 9 months ago
Reviewers:
Yang, danno
CC:
v8-dev
Visibility:
Public.

Description

Fix a bug in the x64 elements transition code. 1. The write barrier (RecordWriteStub) expects that pointer stored points to an initialized object. Specifically, the map must be set before it is stored. 2. The backing store for smi-only elements can only be reused for double elements if it is in new-space. Otherwise, we need to allocate a fresh one because the old one is in pointer-space and the new one has to be in data-space. BUG=117037 Committed: https://code.google.com/p/v8/source/detail?r=10968

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -8 lines) Patch
M src/x64/codegen-x64.cc View 4 chunks +16 lines, -8 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
fschneider
8 years, 9 months ago (2012-03-08 14:41:05 UTC) #1
Yang
8 years, 9 months ago (2012-03-08 14:46:40 UTC) #2
On 2012/03/08 14:41:05, fschneider wrote:

LGTM.

Powered by Google App Engine
This is Rietveld 408576698