media/filters/ffmpeg_decoder_unittest.h - Issue 9632024: Create video and audio decoder threads on demand.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: media/filters/ffmpeg_decoder_unittest.h

Issue 9632024: Create video and audio decoder threads on demand. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Log an error when Initialize is called more than once. Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef MEDIA_FILTERS_FFMPEG_DECODER_UNITTEST_H_

	6 #define MEDIA_FILTERS_FFMPEG_DECODER_UNITTEST_H_

	7

	8 namespace media {

	9 // Used to inject our message loop into the FFmpeg[Audio\|Video\|Decoder.

	10 template<class T> T Identity(T t) { return t; }
	Ami GONE FROM CHROMIUM 2012/03/11 23:43:12 I think you misunderstood my comment about namespa I think you misunderstood my comment about namespace/static. My point was that instead of using an anonymous namespace: namespace { template<class T> T Identity(T t) { return t; } } media code makes such things file-static: template<class T> static T Identity(T t) { return t; } , not that you should move it into the media namespace (or need a new .h). This function is simple enough that duplicating its code in two test.cc files seems fine to me.
	11 } // namespace media

	12

	13 #endif // MEDIA_FILTERS_FFMPEG_DECODER_UNITTEST_H_

OLD	NEW