V8 crashes when profile generator is trying to allocate a raw_entries_ buffer more than 2Gb.

src/profile-generator.h

Index: src/profile-generator.h
diff --git a/src/profile-generator.h b/src/profile-generator.h
index e7a41cbfe9b8f9c211f7d4ceacc06a089b540bc9..d0e261631c610b0d2b9fc5ac3f63a84676f5e631 100644
--- a/src/profile-generator.h
+++ b/src/profile-generator.h
@@ -584,9 +584,9 @@ class HeapEntry BASE_EMBEDDED {
 
   Handle<HeapObject> GetHeapObject();
 
-  static int EntriesSize(int entries_count,
-                         int children_count,
-                         int retainers_count);
+  static size_t EntriesSize(int entries_count,
+			    int children_count,
+			    int retainers_count);

[alexeif, 2012/03/11 11:15:59]

nit: I'm not sure tabs are allowed.

 
  private:
   HeapGraphEdge* children_arr() {
@@ -647,7 +647,7 @@ class HeapSnapshot {
   HeapEntry* natives_root() { return natives_root_entry_; }
   HeapEntry* gc_subroot(int index) { return gc_subroot_entries_[index]; }
   List<HeapEntry*>* entries() { return &entries_; }
-  int raw_entries_size() { return raw_entries_size_; }
+  size_t raw_entries_size() { return raw_entries_size_; }
 
   void AllocateEntries(
       int entries_count, int children_count, int retainers_count);
@@ -687,7 +687,7 @@ class HeapSnapshot {
   char* raw_entries_;
   List<HeapEntry*> entries_;
   bool entries_sorted_;
-  int raw_entries_size_;
+  size_t raw_entries_size_;
 
   friend class HeapSnapshotTester;