Switch-implementation.

frog/leg/tree/nodes.dart

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 interface Visitor<R> {
   R visitBlock(Block node);
   R visitBreakStatement(BreakStatement node);
   R visitCatchBlock(CatchBlock node);
   R visitClassNode(ClassNode node);
   R visitConditional(Conditional node);
@@ skipping 128 matching lines @@
   StringInterpolation asStringInterpolation() => null;
   StringInterpolationPart asStringInterpolationPart() => null;
   SwitchCase asSwitchCase() => null;
   SwitchStatement asSwitchStatement() => null;
   Throw asThrow() => null;
   TryStatement asTryStatement() => null;
   TypeAnnotation asTypeAnnotation() => null;
   Typedef asTypedef() => null;
   VariableDefinitions asVariableDefinitions() => null;
   While asWhile() => null;
+
+  bool isValidBreakTarget() => false;
+  bool isValidContinueTarget() => false;
 }
 
 class ClassNode extends Node {
   final Identifier name;
   final TypeAnnotation superclass;
   final NodeList interfaces;
 
   // Using a NodeList to record the keyword "default".
   // TODO(ahe): Consider if there is a better way to represent this.
   final NodeList defaultClause;
@@ skipping 34 matching lines @@
 }
 
 class Statement extends Node {
   Statement();
 
   Statement asStatement() => this;
 
   // TODO(ahe): make class abstract instead of adding an abstract method.
   abstract accept(Visitor visitor);
 
-  bool isValidContinueTarget() => false;
+  bool isValidBreakTarget() => true;
 }
 
 /**
  * A message send aka method invocation. In Dart, most operations can
  * (and should) be considered as message sends. Getters and setters
  * are just methods with a special syntax. Consequently, we model
  * property access, assignment, operators, and method calls with this
  * one node.
  */
 class Send extends Expression {
@@ skipping 1188 matching lines @@
   visitChildren(Visitor visitor) {
     parenthesizedExpression.accept(visitor);
     cases.accept(visitor);
   }
 
   Token getBeginToken() => switchKeyword;
 
   Token getEndToken() => cases.getEndToken();
 }
 
 class SwitchCase extends Node {

[ahe, 2012/03/13 10:17:15]

A short comment would be helpful, something like:

(label:)? (case: expression)* (default:)? statements;

Each expression is collected in [expressions]; [caseKeywords] can be used to
obtain the begin tokens of each of the cases.

   final Identifier label;
-  final Expression expression;
+  final NodeList expressions;
+  final Token defaultKeyword;
   final NodeList statements;
 
-  final Token caseKeyword;
+  final Token startToken;
 
-  SwitchCase(this.label, this.expression, this.statements, this.caseKeyword);
+  SwitchCase(this.label, this.expressions, this.defaultKeyword,
+             this.statements, this.startToken);
 
   SwitchCase asSwitchCase() => this;
 
+  bool get isDefaultCase() => defaultKeyword !== null;
+
   accept(Visitor visitor) => visitor.visitSwitchCase(this);
 
   visitChildren(Visitor visitor) {
     if (label !== null) label.accept(visitor);
-    expression.accept(visitor);
+    expressions.accept(visitor);
     statements.accept(visitor);
   }
 
   Token getBeginToken() {
-    if (label !== null) return label.getBeginToken();
-    return caseKeyword;
+    return startToken;
   }
 
   Token getEndToken() {
     if (statements.nodes.isEmpty()) {
+      // All cases must have at least one expression or be the default.
+      if (defaultKeyword !== null) {
+        // The colon after 'default'.
+        return defaultKeyword.next;
+      }
       // The colon after the expression.
-      return expression.getEndToken().next;
+      return expressions.getEndToken().next;
     } else {
       return statements.getEndToken();
     }
   }
-}
 
-class DefaultCase extends Node {
-  final Identifier label;
-  final NodeList statements;
-
-  final Token defaultKeyword;
-
-  DefaultCase(this.label, this.statements, this.defaultKeyword);
-
-  DefaultCase asDefaultCase() => this;
-
-  accept(Visitor visitor) => visitor.visitDefaultCase(this);
-
-  visitChildren(Visitor visitor) {
-    if (label !== null) label.accept(visitor);
-    statements.accept(visitor);
-  }
-
-  Token getBeginToken() {
-    if (label !== null) return label.getBeginToken();
-    return defaultKeyword;
-  }
-
-  Token getEndToken() {
-    if (statements.nodes.isEmpty()) {
-      // The colon after default.
-      return defaultKeyword.next;
-    } else {
-      return statements.getEndToken();
+  List<Token> caseKeywords() {

[ahe, 2012/03/13 10:17:15]

Please return a Link for consistency.

[Lasse Reichstein Nielsen, 2012/03/13 12:09:38]

Done.

+    Token token = begin;
+    if (label !== null) {
+      // Skip past <Identifier> ':'.

[ahe, 2012/03/13 10:17:15]

// Skip past the label: <Identifier> ':'.

[Lasse Reichstein Nielsen, 2012/03/13 12:09:38]

Done.

+      token = token.next.next;
     }
+    List<Token> result = <Token>[];
+    while (token.stringValue === "case") {
+      result.add(token);
+      // Skip past 'case' <Expression> ':'.
+      token = token.next.next.next;

[Lasse Reichstein Nielsen, 2012/03/13 12:09:38]

Oh, and this doesn't actually work. Fixing.

+    }
+    return result;
   }
 }
 
 class GotoStatement extends Statement {
   final Identifier target;
   final Token keywordToken;
   final Token semicolonToken;
 
   GotoStatement(this.target, this.keywordToken, this.semicolonToken);
 
@@ skipping 222 matching lines @@
   static bool isConstructorRedirect(Send node) {
     return (node.receiver === null &&
             node.selector.asIdentifier() !== null &&
             node.selector.asIdentifier().isThis()) ||
            (node.receiver !== null &&
             node.receiver.asIdentifier() !== null &&
             node.receiver.asIdentifier().isThis() &&
             node.selector.asIdentifier() !== null);
   }
 }