Error reporting on File in dart:io

runtime/bin/directory_posix.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "bin/directory.h"
 
 #include <dirent.h>
 #include <errno.h>
 #include <sys/param.h>
 #include <sys/stat.h>
 #include <unistd.h>
 
 #include "bin/file.h"
 #include "bin/platform.h"
 
 
 static char* SafeStrNCpy(char* dest, const char* src, size_t n) {
   strncpy(dest, src, n);
   dest[n - 1] = '\0';
   return dest;
 }
 
 
-static void SetOsErrorMessage(char* os_error_message,
-                              int os_error_message_len) {
-  SafeStrNCpy(os_error_message, strerror(errno), os_error_message_len);
-}
-
-
 // Forward declarations.
 static bool ListRecursively(const char* dir_name,
                             bool recursive,
                             DirectoryListing* listing);
 static bool DeleteRecursively(const char* dir_name);
 
 
 static bool ComputeFullPath(const char* dir_name,
                             char* path,
                             int* path_length) {
@@ skipping 342 matching lines @@
 }
 
 
 bool Directory::Create(const char* dir_name) {
   // Create the directory with the permissions specified by the
   // process umask.
   return (TEMP_FAILURE_RETRY(mkdir(dir_name, 0777)) == 0);
 }
 
 
-int Directory::CreateTemp(const char* const_template,
-                          char** path,
-                          char* os_error_message,
-                          int os_error_message_len) {
+char* Directory::CreateTemp(const char* const_template) {
   // Returns a new, unused directory name, modifying the contents of
   // dir_template.  Creates the directory with the permissions specified
   // by the process umask.
   // The return value must be freed by the caller.
-  *path = static_cast<char*>(malloc(PATH_MAX + 1));
-  SafeStrNCpy(*path, const_template, PATH_MAX + 1);
-  int path_length = strlen(*path);
+  char* path = static_cast<char*>(malloc(PATH_MAX + 1));
+  SafeStrNCpy(path, const_template, PATH_MAX + 1);
+  int path_length = strlen(path);
   if (path_length > 0) {
-    if ((*path)[path_length - 1] == '/') {
-      snprintf(*path + path_length, PATH_MAX - path_length, "temp_dir_XXXXXX");
+    if ((path)[path_length - 1] == '/') {
+      snprintf(path + path_length, PATH_MAX - path_length, "temp_dir_XXXXXX");
     } else {
-      snprintf(*path + path_length, PATH_MAX - path_length, "XXXXXX");
+      snprintf(path + path_length, PATH_MAX - path_length, "XXXXXX");
     }
   } else {
-    snprintf(*path, PATH_MAX, "/tmp/temp_dir1_XXXXXX");
+    snprintf(path, PATH_MAX, "/tmp/temp_dir1_XXXXXX");
   }
   char* result;
   do {
-    result = mkdtemp(*path);
+    result = mkdtemp(path);
   } while (result == NULL && errno == EINTR);
   if (result == NULL) {
-    SetOsErrorMessage(os_error_message, os_error_message_len);
-    free(*path);
-    *path = NULL;
-    return errno;
+    free(path);
+    return NULL;
   }
-  return 0;
+  return path;
 }
 
 
 bool Directory::Delete(const char* dir_name, bool recursive) {
   if (!recursive) {
     return (TEMP_FAILURE_RETRY(remove(dir_name)) == 0);
   } else {
     return DeleteRecursively(dir_name);
   }
 }