Save password without an associated username.

webkit/forms/password_form_dom_manager.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef WEBKIT_FORMS_PASSWORD_FORM_DOM_MANAGER_H_
 #define WEBKIT_FORMS_PASSWORD_FORM_DOM_MANAGER_H_
 
 #include <map>
 
 #include "webkit/forms/form_data.h"
@@ skipping 11 matching lines @@
 // basic_data identifies the HTML form on the page and preferred username/
 //            password for login, while
 // additional_logins is a list of other matching user/pass pairs for the form.
 // wait_for_username tells us whether we need to wait for the user to enter
 // a valid username before we autofill the password. By default, this is off
 // unless the PasswordManager determined there is an additional risk
 // associated with this form. This can happen, for example, if action URI's
 // of the observed form and our saved representation don't match up.
 struct WEBKIT_FORMS_EXPORT PasswordFormFillData {
   typedef std::map<string16, string16> LoginCollection;
+  // It used to express the kinds of datas that the instance has.
+  enum DataType {
+    kUsernameAndPassword = 0,
+    kOnlyPassword,
+    kError,  // the instance has wrong datas.
+  };

[Ilya Sherman, 2012/03/22 16:57:44]

There should be no need to add this enum -- you can determine whether there is a
username field based on the size of basic_data.fields.

[Yumikiyo Osanai, 2012/03/26 21:23:43]

Umm... You are right, it seems to be it's a bit verbose.
I've changed the code as you advised.

 
+  // You should set a password basic_data.fields[0].
+  // If there's a username, you should set the username basic_data.fields[1].
   FormData basic_data;
   LoginCollection additional_logins;
   bool wait_for_username;
   PasswordFormFillData();
   ~PasswordFormFillData();
+
+  // Get the username field from basic_data.
+  // If it hasn't any username, calls NOTREACHED().
+  const FormField& GetUsernameField() const;
+
+  // Get the username field from basic_data.
+  const FormField& GetPasswordField() const;
+
+  // Get the DataType.
+  // This function judge the datatype with basic_data.
+  // If basic_data.size() == 2, it judges I have username and password.
+  // If basic_data.size() == 1, it judges I have only password.
+  // Otherwise, it judges I have wrong datas.
+  DataType GetDataType() const;

[Ilya Sherman, 2012/03/22 16:57:44]

There should be no need to add these methods.  This is a struct, so it should
have a trivial interface.  It might be helpful to have the two convenience
methods

const FormField& GetUsernameField(const PasswordFormFillData& fill_data);
const FormField& GetPasswordField(const PasswordFormFillData& fill_data);

defined in an anonymous namespace in password_autofill_manager.cc, though.

[Yumikiyo Osanai, 2012/03/26 21:23:43]

I agree with your idea.
I remove these member methods, and add two functions in anonymous namespace in
password_autofill_manager.cc.

 };
 
 class PasswordFormDomManager {
  public:
   // Create a PasswordForm from DOM form. Webkit doesn't allow storing
   // custom metadata to DOM nodes, so we have to do this every time an event
   // happens with a given form and compare against previously Create'd forms
   // to identify..which sucks.
   WEBKIT_FORMS_EXPORT static PasswordForm* CreatePasswordForm(
       const WebKit::WebFormElement& form);
@@ skipping 10 matching lines @@
                            bool wait_for_username_before_autofill,
                            PasswordFormFillData* result);
  private:
   DISALLOW_IMPLICIT_CONSTRUCTORS(PasswordFormDomManager);
 };
 
 }  // namespace forms
 }  // namespace webkit
 
 #endif  // WEBKIT_FORMS_PASSWORD_FORM_DOM_MANAGER_H__