Save password without an associated username.

chrome/renderer/autofill/password_autofill_manager.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/autofill/password_autofill_manager.h"
 
 #include "base/bind.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/message_loop.h"
 #include "chrome/common/autofill_messages.h"
@@ skipping 37 matching lines @@
 static bool FindFormInputElements(WebKit::WebFormElement* fe,
                                   const webkit::forms::FormData& data,
                                   FormElements* result) {
   // Loop through the list of elements we need to find on the form in order to
   // autofill it. If we don't find any one of them, abort processing this
   // form; it can't be the right one.
   for (size_t j = 0; j < data.fields.size(); j++) {
     WebKit::WebVector<WebKit::WebNode> temp_elements;
     fe->getNamedElements(data.fields[j].name, temp_elements);
 
+    // It's true if the form hasn't the user_name elemtnt for the password.
+    // In this case, we just skip and continue to autofill,
+    // because we'd like to autofill the password if user_name doesn't exist.
+    if (temp_elements.size() == 0) {
+      continue;
+    }

[Ilya Sherman, 2012/03/08 23:48:49]

This doesn't seem like the right change.  We shouldn't ignore form elements that
we failed to find.  Rather, we shouldn't look for username elements when we
don't need them.  I think you're going to want to update
webkit::forms::PasswordFormDomManager::InitFillData() to not add the username
element if the password autofill data includes only a password.

[Yumikiyo Osanai, 2012/03/20 15:53:37]

Done.

+
     // Match the first input element, if any.
     // |getNamedElements| may return non-input elements where the names match,
     // so the results are filtered for input elements.
     // If more than one match is made, then we have ambiguity (due to misuse
     // of "name" attribute) so is it considered not found.
     bool found_input = false;
     for (size_t i = 0; i < temp_elements.size(); ++i) {
       if (temp_elements[i].to<WebKit::WebElement>().hasTagName("input")) {
         // Check for a non-unique match.
         if (found_input) {
@@ skipping 367 matching lines @@
 
     // We might have already filled this form if there are two <form> elements
     // with identical markup.
     if (login_to_password_info_.find(username_element) !=
         login_to_password_info_.end())
       continue;
 
     PasswordInfo password_info;
     password_info.fill_data = form_data;
     password_info.password_field = password_element;
-    login_to_password_info_[username_element] = password_info;
+    login_to_password_info_[password_element] = password_info;
   }
 }
 
 ////////////////////////////////////////////////////////////////////////////////
 // PasswordAutofillManager, private:
 
 void PasswordAutofillManager::GetSuggestions(
     const webkit::forms::PasswordFormFillData& fill_data,
     const string16& input,
     std::vector<string16>* suggestions) {
@@ skipping 130 matching lines @@
   LoginToPasswordInfoMap::iterator iter = login_to_password_info_.find(input);
   if (iter == login_to_password_info_.end())
     return false;
 
   *found_input = input;
   *found_password = iter->second;
   return true;
 }
 
 }  // namespace autofill