Ported NTP4 UI tests to WebUI.

chrome/test/data/webui/ntp4_test.h

+// Copyright (c) 2011 The Chromium Authors. All rights reserved.

[Sheridan Rawlins, 2012/03/07 22:25:36]

2012

[Danh Nguyen, 2012/03/08 16:44:19]

Done.  Thanks.

+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_TEST_DATA_WEBUI_NTP4_TEST_H_
+#define CHROME_TEST_DATA_WEBUI_NTP4_TEST_H_
+#pragma once
+
+#include "chrome/browser/prefs/pref_service.h"
+#include "chrome/browser/profiles/profile.h"
+#include "chrome/browser/ui/browser.h"
+#include "chrome/browser/ui/webui/web_ui_browsertest.h"
+#include "chrome/common/pref_names.h"

[Dan Beam, 2012/03/07 22:49:45]

move all except chrome/browser/ui/webui/web_ui_browsertest.h to .cc

we also forward classname when possible (i.e. if you don't really need to know
much about something other than it's a parameter to a method, you can just say
class ClassName; and include the header for it in the .cc).

[Danh Nguyen, 2012/03/08 16:44:19]

Done.

+
+class NTP4LoggedInWebUITest : public WebUIBrowserTest {
+ public:
+  NTP4LoggedInWebUITest();
+  virtual ~NTP4LoggedInWebUITest();
+
+  // Sets the user name into the profile as if the user had logged in.
+  void SetLoginName(const std::string& loginName);

[Sheridan Rawlins, 2012/03/07 22:25:36]

This can be protected:

[Danh Nguyen, 2012/03/08 16:44:19]

Yes.  Thanks.

+
+  DISALLOW_COPY_AND_ASSIGN(NTP4LoggedInWebUITest);

[Sheridan Rawlins, 2012/03/07 22:25:36]

needs to be in private: section to do any good ;-)

[Dan Beam, 2012/03/07 22:49:45]

to add to what scr@ said, this macro creates copy constructors and it needs to
be in the private section so one can't implicitly make copies via = (and
possibly leak memory and waste resources).

[Danh Nguyen, 2012/03/08 16:44:19]

Doh!  I should have checked the macro.  I thought it was included.

[Danh Nguyen, 2012/03/08 16:44:19]

Thanks, Dan.

+};
+
+#endif  // CHROME_TEST_DATA_WEBUI_NTP4_TEST_H_