Issue 9625011: Set debug break slot at init of loop variable in a for loop.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9625011: Set debug break slot at init of loop variable in a for loop. (Closed)

Created:
8 years, 9 months ago by Yang

Modified:
8 years, 9 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Set debug break slot at init of loop variable in a for loop. BUG=102153 TEST=regress-102153.js Committed: https://code.google.com/p/v8/source/detail?r=10963

Patch Set 2 : #

Total comments: 4

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+68 lines, -10 lines)			Patch
M	src/full-codegen.cc	View		2 chunks	+2 lines, -1 line	1 comment	Download
M	test/cctest/test-debug.cc	View		8 chunks	+8 lines, -8 lines	1 comment	Download
M	test/mjsunit/debug-stepin-accessor.js	View	1	1 chunk	+1 line, -1 line	2 comments	Download
A	test/mjsunit/regress/regress-102153.js	View	1	1 chunk	+57 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Yang

PTAL. http://codereview.chromium.org/9625011/diff/6/src/full-codegen.cc File src/full-codegen.cc (right): http://codereview.chromium.org/9625011/diff/6/src/full-codegen.cc#newcode1178 src/full-codegen.cc:1178: SetStatementPosition(stmt); Only set a debug break slot if ...

8 years, 9 months ago (2012-03-07 18:28:35 UTC) #1

Jakob Kummerow

8 years, 9 months ago (2012-03-08 08:08:45 UTC) #2

LGTM

http://codereview.chromium.org/9625011/diff/6/test/mjsunit/debug-stepin-acces...
File test/mjsunit/debug-stepin-accessor.js (right):

http://codereview.chromium.org/9625011/diff/6/test/mjsunit/debug-stepin-acces...
test/mjsunit/debug-stepin-accessor.js:1: // Copyright 2008 the V8 project
authors. All rights reserved.
2012

Expand Messages | Collapse Messages

Issue 9625011: Set debug break slot at init of loop variable in a for loop. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages