Add the spdy protocol to the information displayed about a spdy session in net-internals.

net/spdy/spdy_session.cc

Index: net/spdy/spdy_session.cc
diff --git a/net/spdy/spdy_session.cc b/net/spdy/spdy_session.cc
index 4b21695d390004b6f112ba36e70ffbda2c442e93..c9b83d118c63e3e37e9f108e9ef13bddef90a76c 100644
--- a/net/spdy/spdy_session.cc
+++ b/net/spdy/spdy_session.cc
@@ -1110,6 +1110,16 @@ Value* SpdySession::GetInfoAsValue() const {
 
   dict->SetBoolean("is_secure", is_secure_);
 
+  SSLClientSocket::NextProto proto = SSLClientSocket::kProtoUnknown;
+  if (is_secure_) {
+    SSLClientSocket* ssl_socket =
+        reinterpret_cast<SSLClientSocket*>(connection_->socket());

[eroman, 2012/03/07 19:27:32]

Are you absolutely sure about this? Reinterpret cast scares the hell out of me.

[mmenke, 2012/03/07 19:32:32]

Drive by comment:  Looks like all the other instances of
reinterpret_cast<SSLClientSocket*> in this file either have a
"DCHECK(is_secure_)" or an "if (is_secure_)".  I'd suggest the latter here,
seeing as if that assumption ever changes, testing of net-internals is pretty
sparse, so it could easily go unnoticed.

[Ryan Hamilton, 2012/03/07 19:46:22]

Heh, yes I agree.  This is already wrapped in an if (is_secure) on line 1114,
right?

[Ryan Hamilton, 2012/03/07 19:46:22]

eroman: yes in the sense that we do this repeatedly in spdy_session.cc:

grep 'reinterpret_cast<SSLClientSocket' net/spdy/spdy_session.cc | wc -l
8

[mmenke, 2012/03/07 19:47:59]

Oops...Indeed it is.  Amusingly, I just looked at other instances of
reinterpret_cast<SSLClientSocket*>, without double-checking that this one had
it.

+    DCHECK(ssl_socket);
+    proto = ssl_socket->protocol_negotiated();
+  }
+  dict->SetString("protocol_negotiated",
+                  SSLClientSocket::NextProtoToString(proto));
+
   dict->SetInteger("error", error_);
   dict->SetInteger("max_concurrent_streams", max_concurrent_streams_);