Add support for using an URL for establishing HTTP connections

runtime/bin/http_impl.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 // Utility class for encoding a string into UTF-8 byte stream.
 class _UTF8Encoder {
   static List<int> encodeString(String string) {
     int size = _encodingSize(string);
     ByteArray result = new ByteArray(size);
     _encodeString(string, result);
@@ skipping 1038 matching lines @@
   _HttpClient() : _openSockets = new Map(),
                   _activeSockets = new Set(),
                   _shutdown = false;
 
   HttpClientConnection open(
       String method, String host, int port, String path) {
     if (_shutdown) throw new HttpException("HttpClient shutdown");
     return _prepareHttpClientConnection(host, port, method, path);
   }
 
+  HttpClientConnection openUrl(String method, Uri url) {
+    if (url.scheme != "http") {
+      throw new HttpException("Unsupported URL scheme ${url.scheme}");
+    }
+    if (url.userInfo != "") {
+      throw new HttpException("Unsupported user info in URL");

[Mads Ager (google), 2012/03/08 08:02:52]

Interpolate the userInfo?

[Søren Gjesse, 2012/03/08 08:30:04]

Done.

+    }
+    int port = url.port == 0 ? HttpClient.DEFAULT_HTTP_PORT : url.port;
+    String path;

[Mads Ager (google), 2012/03/08 08:02:52]

After the sanity checks, could you just use url.toString() instead of
duplicating it here?

[Søren Gjesse, 2012/03/08 08:30:04]

Unfortunately not, at that will add the prefix "http://host:port" as well.

+    if (url.query != "") {
+      if (url.fragment != "") {
+        path = "${url.path}?${url.query}#${url.fragment}";
+      } else {
+        path = "${url.path}?${url.query}";
+      }
+    } else {
+      path = url.path;
+    }
+    return open(method, url.domain, port, path);
+  }
+
   HttpClientConnection get(String host, int port, String path) {
     return open("GET", host, port, path);
   }
 
+  HttpClientConnection getUrl(Uri url) => openUrl("GET", url);
+
   HttpClientConnection post(String host, int port, String path) {
     return open("POST", host, port, path);
   }
 
+  HttpClientConnection postUrl(Uri url) => openUrl("POST", url);
+
   void shutdown() {
      _openSockets.forEach((String key, Queue<_SocketConnection> connections) {
        while (!connections.isEmpty()) {
          _SocketConnection socketConn = connections.removeFirst();
          socketConn._socket.close();
        }
      });
      _activeSockets.forEach((_SocketConnection socketConn) {
        socketConn._socket.close();
      });
@@ skipping 105 matching lines @@
     _onError = callback;
   }
 
   Function _onOpen;
   Function _onError;
   Map<String, Queue<_SocketConnection>> _openSockets;
   Set<_SocketConnection> _activeSockets;
   Timer _evictionTimer;
   bool _shutdown;  // Has this HTTP client been shutdown?
 }