Add support for using an URL for establishing HTTP connections

Add support for using an URL for establishing HTTP connections

As the URI library is now part of the standalone VM it makes sense to
have the option of using a URL for opening a HTTP connection

R=ager@google.com

BUG=
TEST=

Committed: https://code.google.com/p/dart/source/detail?r=5153

[Mads Ager (google), 2012-03-08 08:02:52]

https://chromiumcodereview.appspot.com/9625008/diff/1/runtime/bin/http.dart
File runtime/bin/http.dart (right):

https://chromiumcodereview.appspot.com/9625008/diff/1/runtime/bin/http.dart#n...
runtime/bin/http.dart:237: HttpClientConnection openUrl(String method, Uri url);
Please add doc comment for all three of these.

https://chromiumcodereview.appspot.com/9625008/diff/1/runtime/bin/http_impl.dart
File runtime/bin/http_impl.dart (right):

https://chromiumcodereview.appspot.com/9625008/diff/1/runtime/bin/http_impl.d...
runtime/bin/http_impl.dart:1064: throw new HttpException("Unsupported user info
in URL");
Interpolate the userInfo?

https://chromiumcodereview.appspot.com/9625008/diff/1/runtime/bin/http_impl.d...
runtime/bin/http_impl.dart:1067: String path;
After the sanity checks, could you just use url.toString() instead of
duplicating it here?

[Søren Gjesse, 2012-03-08 08:30:04]

ptal

http://codereview.chromium.org/9625008/diff/1/runtime/bin/http.dart
File runtime/bin/http.dart (right):

http://codereview.chromium.org/9625008/diff/1/runtime/bin/http.dart#newcode237
runtime/bin/http.dart:237: HttpClientConnection openUrl(String method, Uri url);
On 2012/03/08 08:02:52, Mads Ager wrote:
> Please add doc comment for all three of these.

Done.

http://codereview.chromium.org/9625008/diff/1/runtime/bin/http_impl.dart
File runtime/bin/http_impl.dart (right):

http://codereview.chromium.org/9625008/diff/1/runtime/bin/http_impl.dart#newc...
runtime/bin/http_impl.dart:1064: throw new HttpException("Unsupported user info
in URL");
On 2012/03/08 08:02:52, Mads Ager wrote:
> Interpolate the userInfo?

Done.

http://codereview.chromium.org/9625008/diff/1/runtime/bin/http_impl.dart#newc...
runtime/bin/http_impl.dart:1067: String path;
On 2012/03/08 08:02:52, Mads Ager wrote:
> After the sanity checks, could you just use url.toString() instead of
> duplicating it here?

Unfortunately not, at that will add the prefix "http://host:port" as well.

[Mads Ager (google), 2012-03-08 08:41:12]

LGTM