Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2498)

Unified Diff: content/public/common/content_client.cc

Issue 9623027: Move --user-agent overriding logic from chrome into content. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src
Patch Set: rebase Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/public/common/content_client.h ('k') | content/shell/shell_content_client.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/common/content_client.cc
diff --git a/content/public/common/content_client.cc b/content/public/common/content_client.cc
index 9558e2ddd700566e0593dbc85c6afe1031c50758..ae252120d3653623eb01b878305f8c7f47fe36c6 100644
--- a/content/public/common/content_client.cc
+++ b/content/public/common/content_client.cc
@@ -16,17 +16,11 @@ static ContentClient* g_client;
void SetContentClient(ContentClient* client) {
g_client = client;
- // TODO(dpranke): Doing real work (calling webkit_glue::SetUserAgent)
- // inside what looks like a function that initializes a global is a
- // bit odd, but we need to make sure this is done before
- // webkit_glue::GetUserAgent() is called (so that the UA doesn't change).
- //
- // It would be cleaner if we could rename this to something like a
- // content::Initialize(). Maybe we can merge this into ContentMain() somehow?
+ // Set the default user agent as provided by the client. We need to make
+ // sure this is done before webkit_glue::GetUserAgent() is called (so that
+ // the UA doesn't change).
if (client) {
- bool custom = false;
- std::string ua = client->GetUserAgent(&custom);
- webkit_glue::SetUserAgent(ua, custom);
+ webkit_glue::SetUserAgent(client->GetUserAgent(), false);
}
}
« no previous file with comments | « content/public/common/content_client.h ('k') | content/shell/shell_content_client.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698