Issue 9623009: Add one-arg implementations of WebViewClient::createGraphicsContext3D()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9623009: Add one-arg implementations of WebViewClient::createGraphicsContext3D() (Closed)

Created:
8 years, 9 months ago by jamesr

Modified:
8 years, 9 months ago

Reviewers:
darin (slow to review), piman

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, pam+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add one-arg implementations of WebViewClient::createGraphicsContext3D() The 2-arg version of WebViewClient::createGraphicsContext3D() is being deprecated, this adds implementations of the 1-arg version so that we can switch WebKit over. Must land after https://bugs.webkit.org/show_bug.cgi?id=80521 or a few layout tests in platform/chromium/compositing/plugins/ will break. BUG=none TEST=compiles Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=125600

Patch Set 1 #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+15 lines, -0 lines)			Patch
M	content/renderer/render_view_impl.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	content/renderer/render_view_impl.cc	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	webkit/tools/test_shell/test_webview_delegate.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	webkit/tools/test_shell/test_webview_delegate.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/9623009/1

8 years, 9 months ago (2012-03-08 07:00:46 UTC) #4

Change committed as 125600

Expand Messages | Collapse Messages