Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2221)

Unified Diff: client/dom/scripts/generator.py

Issue 9623003: Rename DOMWindow to Window in Dartium bindings. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « client/dom/scripts/dartdomgenerator.py ('k') | client/dom/src/native_DOMImplementation.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: client/dom/scripts/generator.py
diff --git a/client/dom/scripts/generator.py b/client/dom/scripts/generator.py
index a5407d802145a2303f3e8cffd4c4c7901a8ba570..25c02f47e466c6847d82e5cf4487b4a698dd1636 100644
--- a/client/dom/scripts/generator.py
+++ b/client/dom/scripts/generator.py
@@ -488,7 +488,7 @@ class IDLTypeInfo(object):
def webcore_includes(self):
if not self._idl_type.startswith('SVG'):
- return [self._idl_type]
+ return [self.native_type()]
if self._idl_type in ['SVGNumber', 'SVGPoint']:
return []
@@ -608,7 +608,6 @@ _idl_type_registry = {
'CSSRule': IDLTypeInfo('CSSRule', conversion_includes=['CSSImportRule']),
'DOMException': IDLTypeInfo('DOMCoreException', dart_type='DOMException'),
- 'DOMWindow': IDLTypeInfo('DOMWindow', custom_to_dart=True),
'Element': IDLTypeInfo('Element', custom_to_dart=True),
'EventListener': IDLTypeInfo('EventListener', has_dart_wrapper=False),
'EventTarget': IDLTypeInfo('EventTarget', has_dart_wrapper=False),
@@ -617,6 +616,7 @@ _idl_type_registry = {
'OptionsObject': IDLTypeInfo('OptionsObject', has_dart_wrapper=False),
'StyleSheet': IDLTypeInfo('StyleSheet', conversion_includes=['CSSStyleSheet']),
'SVGElement': IDLTypeInfo('SVGElement', custom_to_dart=True),
+ 'Window': IDLTypeInfo('Window', native_type='DOMWindow', custom_to_dart=True),
'SVGAngle': SVGTearOffIDLTypeInfo('SVGAngle'),
'SVGLength': SVGTearOffIDLTypeInfo('SVGLength'),
« no previous file with comments | « client/dom/scripts/dartdomgenerator.py ('k') | client/dom/src/native_DOMImplementation.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698