Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(645)

Issue 9622023: Revert 125441 - In CrMallocErrorBreak, do not kill the process if errno is ENOMEM. (Closed)

Created:
8 years, 9 months ago by viettrungluu
Modified:
8 years, 9 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews, brettw-cc_chromium.org
Visibility:
Public.

Description

Revert 125441 - In CrMallocErrorBreak, do not kill the process if errno is ENOMEM. [Caused test failures on 10.5.] This will allow large JPEG decodes to be handled and optionally killed by the OOM killer instead. Based on a sampling of the other malloc_error_break() bugs ("unaligned pointer", "freed was not allocated", "double free", and "incorrect checksum"), this will only affect the "allocate region" error, as those others happen at free(), rather than malloc(). BUG=103980 TEST=Covered by ProcessUtilTest.MacTerminateOnHeapCorruption Review URL: http://codereview.chromium.org/9597031 TBR=rsesek@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=125464

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -31 lines) Patch
M base/process_util_mac.mm View 2 chunks +1 line, -8 lines 0 comments Download
M base/process_util_unittest.cc View 4 chunks +5 lines, -23 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
viettrungluu
8 years, 9 months ago (2012-03-07 21:56:08 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698