Issue 9621021: DO NOT COMMIT

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9621021: DO NOT COMMIT (Closed)

Created:
8 years, 9 months ago by vandebo (ex-Chrome)

Modified:
8 years, 6 months ago

Reviewers:

CC:
chromium-reviews, Aaron Boodman, darin-cc_chromium.org, mihaip+watch_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

DO NOT COMMIT Example (Chrome side) of extension custom bindings with a wekit idl object.

Patch Set 1 #

Patch Set 2 : Add webkit patch #

Patch Set 3 : Make async with custom callback #

Patch Set 4 : Rebase #

Patch Set 5 : Fix rebase #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+679 lines, -0 lines)			Patch
A	chrome/browser/extensions/api/media_gallery/media_gallery_api.h	View	1 2	1 chunk	+54 lines, -0 lines	0 comments	Download
A	chrome/browser/extensions/api/media_gallery/media_gallery_api.cc	View	1 2	1 chunk	+67 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/extension_function_dispatcher.cc	View	1 2 3	2 chunks	+7 lines, -0 lines	0 comments	Download
M	chrome/chrome_browser_extensions.gypi	View	1 2 3	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/chrome_renderer.gypi	View	1 2 3	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/common/common_resources.grd	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download
A	chrome/common/extensions/api/experimental.mediaGalleries.json	View		1 chunk	+96 lines, -0 lines	0 comments	Download
M	chrome/common/extensions/api/extension_api.cc	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/common/extensions/docs/js/api_page_generator.js	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/renderer/extensions/custom_bindings_util.cc	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/renderer/extensions/extension_dispatcher.cc	View	1 2 3	4 chunks	+6 lines, -0 lines	0 comments	Download
A	chrome/renderer/extensions/media_gallery_custom_bindings.h	View	1 2 3	1 chunk	+28 lines, -0 lines	0 comments	Download
A	chrome/renderer/extensions/media_gallery_custom_bindings.cc	View	1 2 3	1 chunk	+40 lines, -0 lines	0 comments	Download
M	chrome/renderer/renderer_resources.grd	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download
A	chrome/renderer/resources/extensions/experimental.media_galleries_custom_bindings.js	View	1 2 3 4	1 chunk	+29 lines, -0 lines	0 comments	Download
A	webkit.patch	View	1 2	1 chunk	+343 lines, -0 lines	0 comments	Download