Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Unified Diff: tools/testing/dart/test_runner.dart

Issue 9621015: Multitest annotations now accept multiple annotations on one line. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: none outcome is now empty set Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/testing/dart/test_runner.dart
diff --git a/tools/testing/dart/test_runner.dart b/tools/testing/dart/test_runner.dart
index ec72cb7ddcfd44e13c2fb2abd72559f01c2f0a0e..d61423c354209c398e13926118ead561bd4f3905 100644
--- a/tools/testing/dart/test_runner.dart
+++ b/tools/testing/dart/test_runner.dart
@@ -337,10 +337,13 @@ class AnalysisTestOutputImpl extends TestOutputImpl {
}
bool _didMultitestFail(List errors, List staticWarnings) {
- String outcome = testCase.info.multitestOutcome;
- if ((outcome == '' || outcome == 'compile-time error') && errors.length > 0) {
+ Set<String> outcome = testCase.info.multitestOutcome;
+ Expect.isNotNull(outcome);
+ if ((outcome.isEmpty() || outcome.contains('compile-time error'))
+ && errors.length > 0) {
return true;
- } else if (outcome == 'static type error' && staticWarnings.length > 0) {
+ } else if (outcome.contains('static type error')
+ && staticWarnings.length > 0) {
return true;
}
return false;

Powered by Google App Engine
This is Rietveld 408576698