Issue 9621001: Fix private member name mangling.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9621001: Fix private member name mangling. (Closed)

Created:
8 years, 9 months ago by kasperl

Modified:
8 years, 9 months ago

Reviewers:
ngeoffray

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix private member name mangling. Make sure to make all private member names unique (not just the first one) by possibly giving them a library prefix. R=ngeoffray@google.com BUG=http://dartbug.com/1700 TEST=

Patch Set 1 #

Patch Set 2 : Update minfrog. #

Patch Set 3 : Improve private names. #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+72 lines, -39 lines)			Patch
M	frog/library.dart	View	1 2	1 chunk	+32 lines, -16 lines	0 comments	Download
M	frog/member_set.dart	View	1 2	1 chunk	+2 lines, -1 line	0 comments	Download
M	frog/minfrog	View	1 2	5 chunks	+38 lines, -22 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

kasperl

PTAL. I had to make sure to make all the members in the MemberSet have ...

8 years, 9 months ago (2012-03-07 14:23:11 UTC) #3

Still LGTM

Expand Messages | Collapse Messages