Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 9620024: Move ppapi/examples/gles2/ to ppapi/examples/video_decode (Closed)

Created:
8 years, 9 months ago by jamesr
Modified:
8 years, 9 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Move ppapi/examples/gles2/ to ppapi/examples/video_decode I'd like there to be a ppapi example plugin that only uses the pepper 3d context API and not video decode. BUG=none TEST=compiles Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=125490

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -651 lines) Patch
D ppapi/examples/gles2/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
D ppapi/examples/gles2/gles2.cc View 1 chunk +0 lines, -583 lines 0 comments Download
D ppapi/examples/gles2/gles2.html View 1 chunk +0 lines, -18 lines 0 comments Download
A + ppapi/examples/video_decode/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ppapi/examples/video_decode/testdata.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ppapi/examples/video_decode/video_decode.cc View 25 chunks +46 lines, -44 lines 0 comments Download
A + ppapi/examples/video_decode/video_decode.html View 1 chunk +3 lines, -3 lines 0 comments Download
M ppapi/ppapi_tests.gypi View 2 chunks +3 lines, -3 lines 1 comment Download

Messages

Total messages: 5 (0 generated)
jamesr
I've verified that ppapi_examples_video_decode compiles with this patch. I don't have access to any hardware ...
8 years, 9 months ago (2012-03-07 22:26:57 UTC) #1
Ami GONE FROM CHROMIUM
LGTM % nit You'll need an LGTM from ppapi/OWNERS to create the new dir. https://chromiumcodereview.appspot.com/9620024/diff/1/ppapi/ppapi_tests.gypi ...
8 years, 9 months ago (2012-03-07 22:31:19 UTC) #2
jamesr
On 2012/03/07 22:31:19, Ami Fischman wrote: > LGTM % nit > You'll need an LGTM ...
8 years, 9 months ago (2012-03-07 22:35:06 UTC) #3
Ami GONE FROM CHROMIUM
> git cl upload somewhat barfed on testdata.h since it was too big: > Not ...
8 years, 9 months ago (2012-03-07 22:45:55 UTC) #4
piman
8 years, 9 months ago (2012-03-07 23:14:00 UTC) #5
lgtm

Powered by Google App Engine
This is Rietveld 408576698