Issue 9620007: Add HeapProfiler::GetPersistentHandleCount to be able to track the number of persistent handles

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9620007: Add HeapProfiler::GetPersistentHandleCount to be able to track the number of persistent handles (Closed)

Created:
8 years, 9 months ago by jochen (gone - plz use gerrit)

Modified:
8 years, 8 months ago

Reviewers:
Vyacheslav Egorov (Chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

More Reviews

Description

Add HeapProfiler::GetPersistentHandleCount to be able to track the number of persistent handles It turns out that an increasing number of persistent handles is a good signal for bugs in the bindings layer BUG=none TEST=cctest/test-heap-profiler/PersistentHandleCount

Patch Set 1 #

Total comments: 3

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+52 lines, -0 lines)			Patch
M	include/v8-profiler.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/api.cc	View	1 chunk	+5 lines, -0 lines	2 comments	Download
M	src/global-handles.h	View	2 chunks	+8 lines, -0 lines	0 comments	Download
M	src/global-handles.cc	View	3 chunks	+3 lines, -0 lines	0 comments	Download
M	test/cctest/test-heap-profiler.cc	View	1 chunk	+33 lines, -0 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Vyacheslav Egorov (Chromium)

lgtm I will fix formatting and land. https://chromiumcodereview.appspot.com/9620007/diff/1/src/api.cc File src/api.cc (right): https://chromiumcodereview.appspot.com/9620007/diff/1/src/api.cc#newcode6072 src/api.cc:6072: One more ...

8 years, 9 months ago (2012-03-07 17:07:02 UTC) #2

landed

Expand Messages | Collapse Messages