Issue 9620003: Fix ~EnterDebugger eating TerminateExecution requests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9620003: Fix ~EnterDebugger eating TerminateExecution requests (Closed)

Created:
8 years, 9 months ago by Jakob Kummerow

Modified:
8 years, 9 months ago

Reviewers:
Vyacheslav Egorov (Chromium)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fix ~EnterDebugger eating TerminateExecution requests Superseded by https://chromiumcodereview.appspot.com/9620009/.

Patch Set 1 #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -1 line)			Patch
	M	src/debug.cc	View		3 chunks	+11 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Vyacheslav Egorov (Chromium)

8 years, 9 months ago (2012-03-07 13:27:54 UTC) #2

I don't think this is the right fix. 

Pending termination exception might _arrive_ when we are already inside
ClearMirrorCache and it will again eat it.

I think we need to correctly propagate termination exception instead. (e.g.
check pending excption in HandleStackGuardInterrupt and return proper failure
object).

Expand Messages | Collapse Messages