Triage client failures on legium, and add the client tests to our presubmit script.

frog/presubmit.py

 #!/usr/bin/env python
 # Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 # for details. All rights reserved. Use of this source code is governed by a
 # BSD-style license that can be found in the LICENSE file.
 
 import optparse
 import os
 import stat
 import subprocess
 import sys
@@ skipping 152 matching lines @@
     cmd = test_cmd + ['--component=leg', 'leg_only']
     RunCommand(*cmd, verbose=True)
 
     cmd = test_cmd + ['--component=leg', 'frog_native']
     RunCommand(*cmd, verbose=True)
 
     # Run leg on "built-in" tests.
     cmd = test_cmd + ['--component=leg']
     RunCommand(*cmd, verbose=True)
 
+    # Run leg on client tests.
+    cmd = test_cmd + ['--component=legium', 'client']

[ahe, 2012/03/07 12:29:28]

How long does it take to run this?

[ngeoffray, 2012/03/07 12:40:16]

20 seconds on my machine

[ahe, 2012/03/07 12:49:59]

OK. That is good. This is because you're only running the client tests.

Two problems:

1. You did not change dart/frog/scripts/buildbot_annotated_steps.py, so this is
not being run on the build bot.

2. What happens if I run "test.py -cleg -mrelease". My guess: a whole bunch of
tests will fail. It would be better if you remove ", 'client'" above and add
skip sections to all other test suites. It should be possible to invoke "test.py
-cleg -mrelease" without further options. Other teams rely on this.

+    RunCommand(*cmd, verbose=True)
+
 
 if __name__ == '__main__':
   try:
     sys.exit(main())
   except Error as e:
     sys.stderr.write('%s\n' % e)
     sys.exit(1)