Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 9619017: Fix context sharing between channels to be order-independent. (Closed)

Created:
8 years, 9 months ago by piman
Modified:
8 years, 9 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, apatrick_chromium
Visibility:
Public.

Description

Fix context sharing between channels to be order-independent. Ensuring order of channel recreation after a GPU process death is very hard. With this there's not need. A channel is either shared or not, all the "shared" channels share their context together, every other one doesn't share with anything. More restrictive but it's enough for our needs. BUG=116913 TEST=chrome --ui-use-gpu-process, kill GPU process, observe GpuChannelManager::OnEstablishChannel crash doesn't happen. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=125521

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -16 lines) Patch
M content/browser/gpu/browser_gpu_channel_host_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/gpu/gpu_process_host.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/gpu/gpu_process_host.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/gpu_message_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/gpu_message_filter.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M content/common/gpu/gpu_channel_manager.h View 3 chunks +6 lines, -1 line 0 comments Download
M content/common/gpu/gpu_channel_manager.cc View 2 chunks +6 lines, -5 lines 0 comments Download
M content/common/gpu/gpu_messages.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
piman
apatrick: please review ben: OWNERS
8 years, 9 months ago (2012-03-07 19:50:24 UTC) #1
apatrick_chromium
lgtm
8 years, 9 months ago (2012-03-07 20:58:08 UTC) #2
Ben Goodger (Google)
8 years, 9 months ago (2012-03-08 00:48:37 UTC) #3
lgtm

Powered by Google App Engine
This is Rietveld 408576698