Issue 9619002: Implement --download-data for test harness.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9619002: Implement --download-data for test harness. (Closed)

Created:
8 years, 9 months ago by Michael Starzinger

Modified:
8 years, 9 months ago

Reviewers:
Yang

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Implement --download-data for test harness. This allows the test harness to download missing test suite data if necessary. We use the bzip2 archive for test262 because it is faster than cloning the repository and also works without any Mercurial installation. R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=10955

Patch Set 1 #

Total comments: 1

Patch Set 2 : Addressed comments by Yang Guo. #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+53 lines, -2 lines)			Patch
M	test/test262/testcfg.py	View	1	2 chunks	+28 lines, -0 lines	0 comments	Download
M	tools/test.py	View	1	4 chunks	+21 lines, -2 lines	0 comments	Download
M	tools/test-wrapper-gypbuild.py	View	1	2 chunks	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Yang

LGTM with one tiny nit. https://chromiumcodereview.appspot.com/9619002/diff/1/tools/test-wrapper-gypbuild.py File tools/test-wrapper-gypbuild.py (right): https://chromiumcodereview.appspot.com/9619002/diff/1/tools/test-wrapper-gypbuild.py#newcode76 tools/test-wrapper-gypbuild.py:76: result.add_option("--download-data", help="Download missing test ...

8 years, 9 months ago (2012-03-07 12:30:34 UTC) #2

Added new patch set. Landed.

Expand Messages | Collapse Messages