frog/leg/ssa/codegen.dart - Issue 9618053: Introduce the TYPEDEF element, and use it in order to catch passing closures to the DOM. I make the…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: frog/leg/ssa/codegen.dart

Issue 9618053: Introduce the TYPEDEF element, and use it in order to catch passing closures to the DOM. I make the… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: frog/leg/ssa/codegen.dart

===================================================================

--- frog/leg/ssa/codegen.dart (revision 5070)

+++ frog/leg/ssa/codegen.dart (working copy)

@@ -934,7 +934,7 @@

}

void visitIs(HIs node) {

- ClassElement element = node.typeExpression;

+ Element element = node.typeExpression;

LibraryElement coreLibrary = compiler.coreLibrary;

ClassElement objectClass = coreLibrary.find(const SourceString('Object'));

HInstruction input = node.expression;

@@ -976,7 +976,8 @@

checkArray(input, '===');

buffer.add(' || ');

precedence = JSPrecedence.LOGICAL_OR_PRECEDENCE;

- } else if (element.isNative() || isSupertypeOfNativeClass(element)) {

+ } else if (element.isClass() && (element.dynamic.isNative()

+ || isSupertypeOfNativeClass(element))) {

buffer.add("(");

endParen = true;

} else {

« no previous file with comments | « frog/leg/ssa/builder.dart ('k') | frog/tests/native/src/NativeWrappingFunctionFrogTest.dart » ('j') | no next file with comments »