Issue 9618037: Help: Hook up the 'Get help' button.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9618037: Help: Hook up the 'Get help' button. (Closed)

Created:
8 years, 9 months ago by James Hawkins

Modified:
8 years, 9 months ago

Reviewers:
csilv

CC:
chromium-reviews, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Help: Hook up the 'Get help' button. BUG=115139 TEST=none R=csilv Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=125643

Patch Set 2 : Fix typo. #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+39 lines, -45 lines)			Patch
M	chrome/app/chromium_strings.grd	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/app/generated_resources.grd	View		1 chunk	+3 lines, -5 lines	0 comments	Download
M	chrome/browser/resources/help/help.html	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/resources/help/help.js	View		1 chunk	+13 lines, -25 lines	0 comments	Download
M	chrome/browser/ui/webui/help/help_handler.h	View		1 chunk	+5 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/webui/help/help_handler.cc	View	1	3 chunks	+15 lines, -8 lines	0 comments	Download
M	chrome/common/url_constants.cc	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

csilv

LGTM w/ bug fix https://chromiumcodereview.appspot.com/9618037/diff/1/chrome/common/url_constants.cc File chrome/common/url_constants.cc (right): https://chromiumcodereview.appspot.com/9618037/diff/1/chrome/common/url_constants.cc#newcode282 chrome/common/url_constants.cc:282: "https://support.google.com/chromeos/?&p=help"; remove extra &

8 years, 9 months ago (2012-03-07 19:13:44 UTC) #2

James Hawkins

8 years, 9 months ago (2012-03-08 17:49:40 UTC) #3

https://chromiumcodereview.appspot.com/9618037/diff/1/chrome/common/url_const...
File chrome/common/url_constants.cc (right):

https://chromiumcodereview.appspot.com/9618037/diff/1/chrome/common/url_const...
chrome/common/url_constants.cc:282:
"https://support.google.com/chromeos/?&p=help";
On 2012/03/07 19:13:44, csilv wrote:
> remove extra &

Done.

Expand Messages | Collapse Messages

Issue 9618037: Help: Hook up the 'Get help' button. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Fix typo. #

Messages