chrome/browser/chrome_browser_main.cc - Issue 9618021: Infrastructure to improve app mode stub <-> Chrome main communication.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chrome_browser_main.cc

Issue 9618021: Infrastructure to improve app mode stub <-> Chrome main communication. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/chrome_browser_main.cc

diff --git a/chrome/browser/chrome_browser_main.cc b/chrome/browser/chrome_browser_main.cc

index a87da5ae0b9d4db503db3289c9e56da6fe90d0b2..7150b37e67a555088607e6c12440629d3268dab0 100644

--- a/chrome/browser/chrome_browser_main.cc

+++ b/chrome/browser/chrome_browser_main.cc

@@ -82,6 +82,7 @@

#include "chrome/browser/ui/webui/chrome_url_data_manager_backend.h"

#include "chrome/browser/ui/webui/ntp/new_tab_ui.h"

#include "chrome/browser/ui/webui/sync_promo/sync_promo_trial.h"

+#include "chrome/common/app_mode.h"

#include "chrome/common/child_process_logging.h"

#include "chrome/common/chrome_constants.h"

#include "chrome/common/chrome_paths.h"

@@ -1272,8 +1273,7 @@ int ChromeBrowserMainParts::PreCreateThreadsImpl() {

// If we are running in App mode, we do not want to show the importer

// (first run) UI.

if (!first_run_ui_bypass_ &&

- (parsed_command_line().HasSwitch(switches::kApp) ||

- parsed_command_line().HasSwitch(switches::kAppId) ||

+ (app_mode::IsRunningInAppMode() ||

sail 2012/03/06 19:26:35 could we just add a kNoFirstRun to the CommandLine

parsed_command_line().HasSwitch(switches::kNoFirstRun)))

first_run_ui_bypass_ = true;

« no previous file with comments | « chrome/app/chrome_main_app_mode_mac.mm ('k') | chrome/chrome_common.gypi » ('j') | no next file with comments »