Infrastructure to improve app mode stub <-> Chrome main communication.

Infrastructure to improve app mode stub <-> Chrome main communication.

We currently modify the command line to communicate from the launcher to ChromeMain(), this seems like a bad idea in the long run. The aim of this CL is to provide infrastructure to help us going forward.

* Add an IsRunningInAppMode() function we an use to determine that we're using app mode rather than having each callsite check the command line.
* Mac: Add a function to allow access to the ChromeAppModeInfo struct from anywhere in the code, so we don't need to plumb it down to individual callsites.

TEST=Covered by existing tests.
BUG=None


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=125302

[sail, 2012-03-06 19:26:35]

This looks ok but it's hard to tell without seeing the code that uses this. Can
we wait till that part is done before committing this?

https://chromiumcodereview.appspot.com/9618021/diff/1/chrome/browser/chrome_b...
File chrome/browser/chrome_browser_main.cc (right):

https://chromiumcodereview.appspot.com/9618021/diff/1/chrome/browser/chrome_b...
chrome/browser/chrome_browser_main.cc:1276: (app_mode::IsRunningInAppMode() ||
could we just add a kNoFirstRun to the CommandLine instead?

[jeremy, 2012-03-06 23:25:06]

Ready for another look.

[sail, 2012-03-06 23:29:23]

https://chromiumcodereview.appspot.com/9618021/diff/7002/chrome/browser/chrom...
File chrome/browser/chrome_browser_main.cc (right):

https://chromiumcodereview.appspot.com/9618021/diff/7002/chrome/browser/chrom...
chrome/browser/chrome_browser_main.cc:1276: (app_mode::IsRunningInAppMode() ||
Same as last time, can you just add kNoFirstRun to CommandLine instead? There
are a couple of other places where we look for this switch.

https://chromiumcodereview.appspot.com/9618021/diff/7002/chrome/common/app_mo...
File chrome/common/app_mode.h (right):

https://chromiumcodereview.appspot.com/9618021/diff/7002/chrome/common/app_mo...
chrome/common/app_mode.h:11: bool IsRunningInAppMode();
Should this move into shell_integration.h? If not then should SetAppModeInfo()
move into this file?

[jeremy, 2012-03-07 00:39:56]

Other platforms will need to add calls to SetAppModeInfo() in the appropriate
place.

[sail, 2012-03-07 00:42:05]

LGTM!

[commit-bot: I haz the power, 2012-03-07 00:45:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jeremy@chromium.org/9618021/1010

[commit-bot: I haz the power, 2012-03-07 02:41:17]

Change committed as 125302