Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 9618017: Add clobber list to arm inline asm. (Closed)

Created:
8 years, 9 months ago by Han Shen
Modified:
8 years, 9 months ago
CC:
bjanakiraman, asharif
Base URL:
http://git.chromium.org/external/v8.git@master
Visibility:
Public.

Description

Add clobber list to arm inline asm. While enabling "-fstack-protector", compiler generates code in function prologue and epilogue to do stack check. However, without knowing that 'r1', 'r2' and 'r3' is used/destroyed in inline asm, compiler assumes that 'r1', 'r2', or 'r3' can be used exclusively, which leads to a core dump. Fix to this is quite straightforward, just add clobber list to the inlineasm. BUG=None TEST=manually checked the generated asm code,boot up chrome browser successfully with this modification Committed: https://code.google.com/p/v8/source/detail?r=10977

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M src/platform-linux.cc View 2 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Han Shen
Hi Søren and Kevin, could you take a look at this CL? It is related ...
8 years, 9 months ago (2012-03-08 18:23:38 UTC) #1
Søren Gjesse
Forwarding to Yang Guo.
8 years, 9 months ago (2012-03-08 20:34:17 UTC) #2
Yang
8 years, 9 months ago (2012-03-09 10:20:29 UTC) #3
On 2012/03/08 20:34:17, Søren Gjesse wrote:
> Forwarding to Yang Guo.

LGTM and landing.

Powered by Google App Engine
This is Rietveld 408576698