Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Issue 9618007: Adding cautionary note about manifest_version 2 and Chrome 17. (Closed)

Created:
8 years, 9 months ago by Mike West
Modified:
8 years, 9 months ago
CC:
chromium-reviews, mihaip+watch_chromium.org
Visibility:
Public.

Description

Adding cautionary note about manifest_version 2 and Chrome 17. `"manifest_version": 2` doesn't work quite as well in Chrome 17 as we thought it would. Adding some explicit warnings about its status there: I'd like to merge these back to the M18 branch, and remove them once Chrome 19 goes out the door. BUG=116463 TEST= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=125373

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -0 lines) Patch
M chrome/common/extensions/docs/manifest.html View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/common/extensions/docs/manifestVersion.html View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/common/extensions/docs/static/manifest.html View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/common/extensions/docs/static/manifestVersion.html View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Mike West
Adding a warning to the manifest_version docs regarding the not-so-amazing compat. with Chrome 17. Staged ...
8 years, 9 months ago (2012-03-06 14:13:08 UTC) #1
Aaron Boodman
Great, thanks! LGTM
8 years, 9 months ago (2012-03-06 22:45:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkwst@chromium.org/9618007/1
8 years, 9 months ago (2012-03-07 05:42:40 UTC) #3
commit-bot: I haz the power
8 years, 9 months ago (2012-03-07 05:42:43 UTC) #4
Presubmit check for 9618007-1 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Messages **
If this change requires manual test instructions to QA team, add
TEST=[instructions].

** Presubmit Warnings **
This change modifies the extension docs but the generated docs have not been
updated properly. See chrome/common/extensions/docs/README.txt for more info.
(Report problems to tessamac@chromium.org.)
 - Changes to chrome/common/extensions/docs/static/manifest.html not reflected
in generated doc.
 - Changes to chrome/common/extensions/docs/static/manifestVersion.html not
reflected in generated doc.
First build DumpRenderTree, then update the docs by running:
  chrome/common/extensions/docs/build/build.py

Powered by Google App Engine
This is Rietveld 408576698