Issue 9618003: Automatically determine ElementsKind name for debug printing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9618003: Automatically determine ElementsKind name for debug printing (Closed)

Created:
8 years, 9 months ago by danno

Modified:
8 years, 9 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Automatically determine ElementsKind name for debug printing R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=10941

Patch Set 1 #

Total comments: 5

Patch Set 2 : Fix lint issues #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+74 lines, -47 lines)			Patch
M	src/elements.h	View	1	2 chunks	+5 lines, -1 line	0 comments	Download
M	src/elements.cc	View	1	9 chunks	+66 lines, -2 lines	0 comments	Download
M	src/objects.cc	View		1 chunk	+3 lines, -44 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

8 years, 9 months ago (2012-03-06 10:07:42 UTC) #2

LGTM with nits.

https://chromiumcodereview.appspot.com/9618003/diff/1/src/elements.cc
File src/elements.cc (right):

https://chromiumcodereview.appspot.com/9618003/diff/1/src/elements.cc#newcode345
src/elements.cc:345: FastObjectElementsAccessor(const char* name)
explicit

https://chromiumcodereview.appspot.com/9618003/diff/1/src/elements.cc#newcode426
src/elements.cc:426: FastDoubleElementsAccessor(const char* name)
explicit

https://chromiumcodereview.appspot.com/9618003/diff/1/src/elements.cc#newcode472
src/elements.cc:472: ExternalElementsAccessor(const char* name)
explicit

https://chromiumcodereview.appspot.com/9618003/diff/1/src/elements.cc#newcode520
src/elements.cc:520: ExternalByteElementsAccessor(const char* name)
make ALL the ctors explicit! (more below)

https://chromiumcodereview.appspot.com/9618003/diff/1/src/elements.h
File src/elements.h (right):

https://chromiumcodereview.appspot.com/9618003/diff/1/src/elements.h#newcode40
src/elements.h:40: ElementsAccessor(const char* name) : name_(name) { }
explicit

Expand Messages | Collapse Messages