Chromoting: Implemented security attention sequence (SAS) emulation on Windows.

remoting/host/desktop_environment.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "remoting/host/desktop_environment.h"
 
 #include "base/bind.h"
 #include "base/compiler_specific.h"
 #include "remoting/host/capturer.h"
 #include "remoting/host/chromoting_host.h"
 #include "remoting/host/chromoting_host_context.h"
 #include "remoting/host/event_executor.h"
 
+#if defined(OS_WIN)
+#include "remoting/host/session_event_executor_win.h"
+#endif
+
 namespace remoting {
 
 // static
 DesktopEnvironment* DesktopEnvironment::Create(ChromotingHostContext* context) {
   scoped_ptr<Capturer> capturer(Capturer::Create());
   scoped_ptr<EventExecutor> event_executor(

[Wez, 2012/03/08 22:58:55]

nit: Since the EventExecutor interface doesn't add anything over InputStub, I
think the DesktopEnvironment should return an InputStub here - my suggested
re-parenting of SessionEventExecutor from EventExecutor to InputStub would
require that change - the EventExecutor interface could actually go away
entirely....

[alexeypa (please no reviews), 2012/03/09 01:13:54]

Done.

-      EventExecutor::Create(context->desktop_message_loop(), capturer.get()));
+      EventExecutor::Create(context->desktop_message_loop(),
+                            capturer.get()));
 
   if (capturer.get() == NULL || event_executor.get() == NULL) {
     LOG(ERROR) << "Unable to create DesktopEnvironment";
     return NULL;
   }
 
+#if defined(OS_WIN)
+  event_executor.reset(new SessionEventExecutor(context->desktop_message_loop(),
+                                                context->io_message_loop(),
+                                                event_executor.Pass()));

[Wez, 2012/03/08 22:58:55]

nit: This is a shame; we really only want to use this implementation when
running in the daemon, so we should be able to choose the impl to use.

DesktopEnvironment was supposed to be an interface that lets the implementations
be chosen on a per-application basis, for this reason. :-/

[alexeypa (please no reviews), 2012/03/09 01:13:54]

Not true. We need SessionEventExecutor to switch between desktops to handle UAC.
I could drag this into event_executor_win.cc at the cost of passing
io_meesage_loop to each EventExecutor::Create instance. I don't think you want
that.

[Wez, 2012/03/09 22:24:34]

No we don't - we won't be running with sufficient privileges to switch desktops
to see UAC prompts, since they're privileged.
No, definitely not.  The idea is that DesktopEnvironment is just an interface
that each application running a ChromotingHost implements, with an
IT2MeDesktopEnvironment, and a Me2MeDesktopEnvironment, for example, that know
how to create the relevant application- and platform-specific classes.

[alexeypa (please no reviews), 2012/03/10 18:08:52]

Yes, you are right. we should think about that scenario then. It is It2Me so UAC
prompts will happen. The good thing is that there will be a person to click on
them, but it would be nice just to specify level of access when sharing the
screen. Something like: a user shares the screen and optionally click on the
elevation button. It shows UAC prompt and if the user agrees the host will be
elevated and the remote user will be able to see other desktops.

+#endif
+
   return new DesktopEnvironment(context,
                                 capturer.release(),
                                 event_executor.release());
 }
 
 DesktopEnvironment::DesktopEnvironment(ChromotingHostContext* context,
                                        Capturer* capturer,
                                        EventExecutor* event_executor)
     : host_(NULL),
       context_(context),
       capturer_(capturer),
       event_executor_(event_executor) {
 }
 
 DesktopEnvironment::~DesktopEnvironment() {
 }
 
 }  // namespace remoting