Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Unified Diff: content/browser/accessibility/dump_accessibility_tree_helper_mac.mm

Issue 9617019: Improve formatting of accessibility tests that dump the tree. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix Linux build error, tolerate different line endings Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/accessibility/dump_accessibility_tree_helper_mac.mm
diff --git a/content/browser/accessibility/dump_accessibility_tree_helper_mac.mm b/content/browser/accessibility/dump_accessibility_tree_helper_mac.mm
index 949fe9c7932d5a329ddf4ac1586c35555466b42b..6105adc55f7e9dee5e95ddb8d58e43b8ba9bac4f 100644
--- a/content/browser/accessibility/dump_accessibility_tree_helper_mac.mm
+++ b/content/browser/accessibility/dump_accessibility_tree_helper_mac.mm
@@ -13,13 +13,16 @@
void DumpAccessibilityTreeHelper::Initialize() {}
-string16 DumpAccessibilityTreeHelper::ToString(BrowserAccessibility* node) {
+string16 DumpAccessibilityTreeHelper::ToString(BrowserAccessibility* node,
+ char* prefix) {
BrowserAccessibilityCocoa* cocoa_node = node->toBrowserAccessibilityCocoa();
- NSString* dump = [NSString stringWithFormat:@"%@|%@|%@|%@",
- [cocoa_node role],
- [cocoa_node subrole],
- [cocoa_node title],
- [cocoa_node value]];
+ NSString* dump =
+ [NSString stringWithFormat:@"%s%@ subrole=%@ title='%@' value='%@'\n",
+ prefix,
+ [cocoa_node role],
+ [cocoa_node subrole],
+ [cocoa_node title],
+ [cocoa_node value]];
std::string tempVal = [dump cStringUsingEncoding:NSUTF8StringEncoding];
return UTF8ToUTF16(tempVal);
@@ -34,7 +37,3 @@ const FilePath::StringType DumpAccessibilityTreeHelper::GetExpectedFileSuffix()
const {
return FILE_PATH_LITERAL("-expected-mac.txt");
}
-
-const string16 DumpAccessibilityTreeHelper::GetLineEnding() const {
- return UTF8ToUTF16("\n");
-}

Powered by Google App Engine
This is Rietveld 408576698