Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(428)

Issue 9617006: Replace uint64_t type with ObjectId and use uint32_t as the base for ObjectId type. (Closed)

Created:
8 years, 9 months ago by loislo
Modified:
8 years, 9 months ago
CC:
yurys, alexeif
Visibility:
Public.

Description

We have a problem with really big apps. The snapshot for such pages doesn't fit into JS heap on DevTools front-end side. I'd like to move the snapshot's nodes data into Int32Array. This will reduce the pressure. At this moment it is not possible because the snapshot uses uint64_t for ids. BUG=none TEST=profiler-generator tests

Patch Set 1 #

Total comments: 1

Patch Set 2 : Alexey's comment addressed. I've landed a patch for GetHash functuion. http://trac.webkit.org/chang… #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -44 lines) Patch
M src/profile-generator.h View 1 8 chunks +22 lines, -20 lines 0 comments Download
M src/profile-generator.cc View 1 12 chunks +21 lines, -21 lines 2 comments Download
M src/profile-generator-inl.h View 1 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
loislo
8 years, 9 months ago (2012-03-06 14:36:13 UTC) #1
mnaganov (inactive)
On 2012/03/06 14:36:13, loislo wrote: It's an interesting idea. But I have a concern about ...
8 years, 9 months ago (2012-03-06 14:56:03 UTC) #2
alexeif
https://chromiumcodereview.appspot.com/9617006/diff/1/src/profile-generator.cc File src/profile-generator.cc (right): https://chromiumcodereview.appspot.com/9617006/diff/1/src/profile-generator.cc#newcode3538 src/profile-generator.cc:3538: STATIC_CHECK(sizeof(uint32_t) == sizeof(entry->id())); // NOLINT It should be 'unsigned'. ...
8 years, 9 months ago (2012-03-06 16:07:52 UTC) #3
loislo
8 years, 9 months ago (2012-03-08 13:29:08 UTC) #4
mnaganov (inactive)
8 years, 9 months ago (2012-03-08 15:31:22 UTC) #5
LGTM with comments

https://chromiumcodereview.appspot.com/9617006/diff/2001/src/profile-generato...
File src/profile-generator.cc (right):

https://chromiumcodereview.appspot.com/9617006/diff/2001/src/profile-generato...
src/profile-generator.cc:1475: Handle<HeapObject>
HeapSnapshotsCollection::FindHeapObjectById(SnapshotObjectId id) {
nit: 80 chars

https://chromiumcodereview.appspot.com/9617006/diff/2001/src/profile-generato...
src/profile-generator.cc:3532: + MaxDecimalDigitsIn<sizeof(uint32_t)>::kUnsigned
 // NOLINT
Perhaps, using SnapshotObjectId here will make it clear, why we want to always
use 32-bit type?

Powered by Google App Engine
This is Rietveld 408576698