Issue 9616051: Skip folding until scanning is performant

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9616051: Skip folding until scanning is performant (Closed)

Created:
8 years, 9 months ago by danrubel

Modified:
8 years, 9 months ago

Reviewers:
devoncarew, messick, pquitslund

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Skip folding until scanning is performant Committed: https://code.google.com/p/dart/source/detail?r=5095

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -0 lines)			Patch
	M	editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/text/folding/DefaultDartFoldingStructureProvider.java	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

danrubel

This workaround turns off folding so that large files are opened more quickly. Once we ...

8 years, 9 months ago (2012-03-07 02:17:04 UTC) #1

pquitslund

LGTM! I'm super excited to check this out as I spent a bunch of time ...

8 years, 9 months ago (2012-03-07 04:49:56 UTC) #2

danrubel

8 years, 9 months ago (2012-03-07 14:46:51 UTC) #3

https://chromiumcodereview.appspot.com/9616051/diff/1/editor/tools/plugins/co...
File
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/text/folding/DefaultDartFoldingStructureProvider.java
(right):

https://chromiumcodereview.appspot.com/9616051/diff/1/editor/tools/plugins/co...
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/text/folding/DefaultDartFoldingStructureProvider.java:1472:
DartX.todo();
On 2012/03/07 04:49:56, pquitslund wrote:
> Are we tracking these todo() calls?  I've been using the TODO($user.name):
> comment convention, but maybe I should do this moving ahead?

Good point. Comment adjusted.

Expand Messages | Collapse Messages