Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Side by Side Diff: test/mjsunit/object-define-property.js

Issue 9616016: Make the runtime entry for setting/changing accessors "atomic". (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Incorporated review comments. Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/x64/full-codegen-x64.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2010 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
11 // with the distribution. 11 // with the distribution.
(...skipping 484 matching lines...) Expand 10 before | Expand all | Expand 10 after
496 496
497 try { 497 try {
498 %DefineOrRedefineDataProperty({}, null, null, null); 498 %DefineOrRedefineDataProperty({}, null, null, null);
499 } catch (e) { 499 } catch (e) {
500 assertTrue(/illegal access/.test(e)); 500 assertTrue(/illegal access/.test(e));
501 } 501 }
502 502
503 // Defining properties null should fail even when we have 503 // Defining properties null should fail even when we have
504 // other allowed values 504 // other allowed values
505 try { 505 try {
506 %DefineOrRedefineAccessorProperty(null, 'foo', 0, func, 0); 506 %DefineOrRedefineAccessorProperty(null, 'foo', func, null, 0);
507 } catch (e) { 507 } catch (e) {
508 assertTrue(/illegal access/.test(e)); 508 assertTrue(/illegal access/.test(e));
509 } 509 }
510 510
511 try { 511 try {
512 %DefineOrRedefineDataProperty(null, 'foo', 0, 0); 512 %DefineOrRedefineDataProperty(null, 'foo', 0, 0);
513 } catch (e) { 513 } catch (e) {
514 assertTrue(/illegal access/.test(e)); 514 assertTrue(/illegal access/.test(e));
515 } 515 }
516 516
(...skipping 561 matching lines...) Expand 10 before | Expand all | Expand 10 after
1078 1078
1079 1079
1080 // Regression test: We should never observe the hole value. 1080 // Regression test: We should never observe the hole value.
1081 var objectWithGetter = {}; 1081 var objectWithGetter = {};
1082 objectWithGetter.__defineGetter__('foo', function() {}); 1082 objectWithGetter.__defineGetter__('foo', function() {});
1083 assertEquals(undefined, objectWithGetter.__lookupSetter__('foo')); 1083 assertEquals(undefined, objectWithGetter.__lookupSetter__('foo'));
1084 1084
1085 var objectWithSetter = {}; 1085 var objectWithSetter = {};
1086 objectWithSetter.__defineSetter__('foo', function(x) {}); 1086 objectWithSetter.__defineSetter__('foo', function(x) {});
1087 assertEquals(undefined, objectWithSetter.__lookupGetter__('foo')); 1087 assertEquals(undefined, objectWithSetter.__lookupGetter__('foo'));
OLDNEW
« no previous file with comments | « src/x64/full-codegen-x64.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698