Issue 9615008: Inline Math.random in crankshaft (ia32).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9615008: Inline Math.random in crankshaft (ia32). (Closed)

Created:
8 years, 9 months ago by Yang

Modified:
8 years, 9 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Inline Math.random in crankshaft (ia32). BUG= TEST=cctest/test-random.cc Committed: https://code.google.com/p/v8/source/detail?r=10939

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Total comments: 2

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+171 lines, -5 lines)			Patch
M	src/ia32/lithium-codegen-ia32.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/ia32/lithium-codegen-ia32.cc	View	1 2 3	2 chunks	+57 lines, -3 lines	2 comments	Download
M	test/cctest/SConscript	View	1	2 chunks	+2 lines, -1 line	0 comments	Download
M	test/cctest/cctest.gyp	View	1	2 chunks	+2 lines, -1 line	0 comments	Download
A	test/cctest/test-random.cc	View	1	1 chunk	+109 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

8 years, 9 months ago (2012-03-06 10:49:30 UTC) #2

LGTM

http://codereview.chromium.org/9615008/diff/2007/src/ia32/lithium-codegen-ia3...
File src/ia32/lithium-codegen-ia32.cc (right):

http://codereview.chromium.org/9615008/diff/2007/src/ia32/lithium-codegen-ia3...
src/ia32/lithium-codegen-ia32.cc:3070: const int kSeedSize = sizeof(uint32_t);
static?

http://codereview.chromium.org/9615008/diff/2007/src/ia32/lithium-codegen-ia3...
src/ia32/lithium-codegen-ia32.cc:3074: const int kRandomSeedOffset =
static?

Expand Messages | Collapse Messages