Issue 9614002: Use SyncMessageFilter to Send() ipc messages from background threads.

Issue 9614002: Use SyncMessageFilter to Send() ipc messages from background threads. (Closed)

Created:
8 years, 9 months ago by michaeln

Modified:
8 years, 9 months ago

Reviewers:
dgrogan

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Use SyncMessageFilter to Send() ipc messages from background threads. TBR=jam Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=125233

Patch Set 3 : #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -8 lines)			Patch
M	content/common/web_database_observer_impl.h	View	1	3 chunks	+4 lines, -4 lines	0 comments	Download
M	content/common/web_database_observer_impl.cc	View	1 2	2 chunks	+3 lines, -2 lines	0 comments	Download
M	content/renderer/render_thread_impl.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	content/worker/worker_thread.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

michaeln

https://chromiumcodereview.appspot.com/9614002/diff/4001/content/common/web_database_observer_impl.cc File content/common/web_database_observer_impl.cc (right): https://chromiumcodereview.appspot.com/9614002/diff/4001/content/common/web_database_observer_impl.cc#newcode162 content/common/web_database_observer_impl.cc:162: // JUNK TO INDUCE ERRORS oh... nevermind this JUNK ...

8 years, 9 months ago (2012-03-06 00:39:18 UTC) #2

dgrogan

LGTM https://chromiumcodereview.appspot.com/9614002/diff/4001/content/common/web_database_observer_impl.h File content/common/web_database_observer_impl.h (right): https://chromiumcodereview.appspot.com/9614002/diff/4001/content/common/web_database_observer_impl.h#newcode46 content/common/web_database_observer_impl.h:46: scoped_refptr<IPC::SyncMessageFilter> sender_; If a raw pointer was safe ...

8 years, 9 months ago (2012-03-06 00:51:49 UTC) #3

michaeln

https://chromiumcodereview.appspot.com/9614002/diff/4001/content/common/web_database_observer_impl.h File content/common/web_database_observer_impl.h (right): https://chromiumcodereview.appspot.com/9614002/diff/4001/content/common/web_database_observer_impl.h#newcode46 content/common/web_database_observer_impl.h:46: scoped_refptr<IPC::SyncMessageFilter> sender_; On 2012/03/06 00:51:49, dgrogan wrote: > If ...

8 years, 9 months ago (2012-03-06 01:14:51 UTC) #4

dgrogan

8 years, 9 months ago (2012-03-06 01:16:24 UTC) #5

https://chromiumcodereview.appspot.com/9614002/diff/4001/content/common/web_d...
File content/common/web_database_observer_impl.h (right):

https://chromiumcodereview.appspot.com/9614002/diff/4001/content/common/web_d...
content/common/web_database_observer_impl.h:46:
scoped_refptr<IPC::SyncMessageFilter> sender_;
On 2012/03/06 01:14:51, michaeln wrote:
> On 2012/03/06 00:51:49, dgrogan wrote:
> > If a raw pointer was safe enough before...
> 
> ...and if it really wasn't?

Ok, I suspected that might have been the case.

Expand Messages | Collapse Messages